Skip to content

magento/magento2#15775: [Forwardport] Incorrect return type getList() in CustomerRepository. #20181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 1, 2019
Merged

magento/magento2#15775: [Forwardport] Incorrect return type getList() in CustomerRepository. #20181

merged 1 commit into from
Oct 1, 2019

Conversation

p-bystritsky
Copy link
Contributor

Description

Fixed Issues (if relevant)

  1. Incorrect return type getList() in CustomerRepository #15775: Incorrect return type getList() in CustomerRepository

Manual testing scenarios

  1. Install attached module.
    test-module.zip
  2. Execute command bin/magento foo:bar:test
  3. Command output should be Passed

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @p-bystritsky. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@sivaschenko sivaschenko self-assigned this Jan 10, 2019
@orlangur orlangur self-assigned this Jan 10, 2019
orlangur
orlangur requested changes Jan 10, 2019
View reviewed changes
Copy link
Contributor

@orlangur orlangur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@p-bystritsky do we really need to create real classes instead of virtual types?

@p-bystritsky
Copy link
Contributor Author

@p-bystritsky do we really need to create real classes instead of virtual types?

@orlangur I have no idea how to use virtual types in this case.

@sivaschenko
Copy link
Member

@orlangur we cannot make virtual types to implement an interface.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.1 milestone Jan 14, 2019
@magento-engcom-team
Copy link
Contributor

Hi @sivaschenko, thank you for the review.
ENGCOM-3855 has been created to process this Pull Request

@okorshenko okorshenko removed this from the Release: 2.3.1 milestone Jan 28, 2019
@p-bystritsky p-bystritsky self-assigned this Mar 6, 2019
@p-bystritsky
Copy link
Contributor Author

Waiting for the architect's approvement.

@orlangur
Copy link
Contributor

orlangur commented Apr 3, 2019

@p-bystritsky please add a link to architecture issue or something.

@orlangur
Copy link
Contributor

orlangur commented Apr 4, 2019

Closing due to inactivity. Feel free to reach me out anytime later if you wish to continue work on this pull request and it will be reopened.
Thanks for collaboration!

@ghost ghost assigned sivaschenko Sep 27, 2019
@magento-engcom-team
Copy link
Contributor

Hi @sivaschenko, thank you for the review.
ENGCOM-5964 has been created to process this Pull Request
✳️ @sivaschenko, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@engcom-Golf engcom-Golf self-assigned this Sep 30, 2019
@sidolov sidolov added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Sep 30, 2019
@magento-engcom-team magento-engcom-team mentioned this pull request Oct 1, 2019
Closed
magento-engcom-team pushed a commit that referenced this pull request Oct 1, 2019
@sidolov
ENGCOM-5964: #15775: [Forwardport] Incorrect return type getList() in…
0300ae4 
… CustomerRepository. #20181
@magento-engcom-team magento-engcom-team merged commit 36ad18a into magento:2.3-develop Oct 1, 2019
@m2-assistant
Copy link

m2-assistant bot commented Oct 1, 2019

Hi @p-bystritsky, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.4 milestone Oct 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sivaschenko sivaschenko sivaschenko approved these changes

@akaplya akaplya Awaiting requested review from akaplya

@YevSent YevSent Awaiting requested review from YevSent

@melnikovi melnikovi Awaiting requested review from melnikovi

@paliarush paliarush Awaiting requested review from paliarush

@tariqjawed83 tariqjawed83 Awaiting requested review from tariqjawed83

@orlangur orlangur Awaiting requested review from orlangur

@sidolov sidolov Awaiting requested review from sidolov

Assignees

@sivaschenko sivaschenko

@engcom-Golf engcom-Golf

Labels
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Component: AsynchronousOperations Component: Catalog Component: Cms Component: Customer Component: Eav Component: Quote Component: SalesRule Component: Signifyd Component: Tax Progress: accept Release Line: 2.3
Projects
None yet
Milestone
Release: 2.3.4
Development

Successfully merging this pull request may close these issues.
10 participants
@p-bystritsky @magento-engcom-team @sivaschenko @orlangur @VasylShvorak @sidolov @Nazar65 @davidverholen @okorshenko @engcom-Golf