Skip to content

[Backport] Refactoring magento sales sequence #20086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

agorbulin
Copy link

Original Pull Request

#19930

Description (*)

Refactoring in Magento_SalesSequence module

  • remove unused classes
  • enrich/fix PHPDocs

Fixed Issues (if relevant)

none

Manual testing scenarios (*)

not needed

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @agorbulin. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team magento-engcom-team added Component: SalesRule Component: SalesSequence Release Line: 2.2 Partner: ISM eCompany Pull Request is created by partner ISM eCompany partners-contribution Pull Request is created by Magento Partner labels Jan 5, 2019
@sidolov
Copy link
Contributor

sidolov commented Jan 5, 2019

Hi @agorbulin , due to changes in Magento Code Contributions Guide we can't accept such Pull Requests to 2.2 release line. All code cleanup like typos, spelling mistakes, removing unused code, etc should be delivered to 2.3 release line.
Thank you!

@sidolov sidolov closed this Jan 5, 2019
@ghost
Copy link

ghost commented Jan 5, 2019

Hi @agorbulin, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: SalesRule Component: SalesSequence Partner: ISM eCompany Pull Request is created by partner ISM eCompany partners-contribution Pull Request is created by Magento Partner Release Line: 2.2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants