Skip to content

Fix issue 19887 creating new shipment: getting all trackers. #19981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 4, 2019
Merged

Fix issue 19887 creating new shipment: getting all trackers. #19981

merged 2 commits into from
Jan 4, 2019

Conversation

Nazar65
Copy link
Member

@Nazar65 Nazar65 commented Dec 26, 2018

Description (*)

After creating new shipment customer receive email with all my tracking number

Fixed Issues (if relevant)

  1. creating new shipment: gettting all trackers. after this commit 2307e16 #19887: Issue title

Manual testing scenarios (*)

  1. after creating new shipment and exec $_shipment->getAllTracks()
  2. in https://example.com/admin_xxxxx/admin/order_shipment/view/shipment_id/382
  3. after tick Notify Customer by Email and click save
  4. the customer receive email with all my tracking number

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @Nazar65. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@VladimirZaets VladimirZaets self-assigned this Dec 27, 2018
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.1 milestone Dec 27, 2018
@magento-engcom-team
Copy link
Contributor

Hi @VladimirZaets, thank you for the review.
ENGCOM-3755 has been created to process this Pull Request

@ghost
Copy link

ghost commented Jan 4, 2019

Hi @Nazar65, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team
Copy link
Contributor

Hi @Nazar65. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

1 similar comment
@magento-engcom-team
Copy link
Contributor

Hi @Nazar65. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

<br />
<table class="shipment-track">
<thead>
<?php $trackCollection = $_order->getTracksCollection($_shipment->getId()) ?>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getTracksCollection () doesn't accept argument, does it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants