Skip to content

Move website_name column into columnSet #19914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 4, 2019

Conversation

bradleyfrye
Copy link
Contributor

@bradleyfrye bradleyfrye commented Dec 20, 2018

Description (*)

One column was outside the columnset in this layout, for some reason. Moving this so the grid shows the user's website name.

Fixed Issues (if relevant)

Manual testing scenarios (*)

  1. In admin, go Sales > Orders, click the Create New Order button.
  2. Ensure the customer grid's rightmost column is now a column with header Website, which should match up with the column set in this layout file.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

One column was outside the columnset in this layout, for some reason.  Moving this so the grid shows the user's website name
@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Dec 20, 2018

CLA assistant check
All committers have signed the CLA.

@magento-engcom-team
Copy link
Contributor

Hi @bradleyfrye. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team
Copy link
Contributor

Hi @sidolov, thank you for the review.
ENGCOM-3733 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

@bradleyfrye thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@ghost
Copy link

ghost commented Jan 4, 2019

Hi @bradleyfrye, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team merged commit 5bde1d9 into magento:2.3-develop Jan 4, 2019
@magento-engcom-team
Copy link
Contributor

Hi @bradleyfrye. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

1 similar comment
@magento-engcom-team
Copy link
Contributor

Hi @bradleyfrye. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants