Skip to content

Fixed The ui-component field validation error not opening accordion tab that owns the field (field does not get focused) #19812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 19, 2019

Conversation

ravi-chandra3197
Copy link
Contributor

@ravi-chandra3197 ravi-chandra3197 commented Dec 15, 2018

Description (*)

Fixed The ui-component field validation error not opening accordion tab that owns the field (field does not get focused)

Fixed Issues (if relevant)

  1. The ui-component field validation error not opening accordion tab that owns the field (field does not get focused) #17926: The ui-component field validation error not opening accordion tab that owns the field (field does not get focused)

Manual testing scenarios (*)

  1. N/A

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

ravi-chandra3197 and others added 2 commits December 10, 2018 15:23
…ab that owns the field (field does not get focused)
@magento-engcom-team
Copy link
Contributor

Hi @ravi-chandra3197. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@ravi-chandra3197
Copy link
Contributor Author

Hello @slavvka
I have updated my code can review it.

@sivaschenko sivaschenko self-assigned this Jan 10, 2019
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.1 milestone Jan 10, 2019
@magento-engcom-team
Copy link
Contributor

Hi @sivaschenko, thank you for the review.
ENGCOM-3822 has been created to process this Pull Request

@sivaschenko
Copy link
Member

Hi @ravi-chandra3197 can you please squash this pull request to a single commit? (to remove unnecessary merge commits)

@sivaschenko sivaschenko changed the base branch from 2.3-develop to 2.2-develop January 16, 2019 11:56
@sivaschenko sivaschenko changed the base branch from 2.2-develop to 2.3-develop January 16, 2019 11:57
@sivaschenko
Copy link
Member

Hi @ravi-chandra3197 I managed to remove the problematic merge commits from this pull request by changing base branch and changing it back. Looks like github issue

@ravi-chandra3197
Copy link
Contributor Author

Hello @sivaschenko
Thank you very much for the help.

@ghost
Copy link

ghost commented Jan 19, 2019

Hi @ravi-chandra3197, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento-engcom-team pushed a commit that referenced this pull request Jan 19, 2019
…g accordion tab that owns the field (field does not get focused) #19812
@magento-engcom-team
Copy link
Contributor

Hi @ravi-chandra3197. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

@aagasi
Copy link

aagasi commented Feb 16, 2019

Hi @ravi-chandra3197, your fix works as expected when editing a product in the admin.

I'm wondering if there is also a similar fix for the admin configuration page (admin/admin/system_config/). That section contains collapsibles also, and it'll be very helpful to have your fix implemented there also.

Thanks,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants