-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Fixed The ui-component field validation error not opening accordion tab that owns the field (field does not get focused) #19812
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed The ui-component field validation error not opening accordion tab that owns the field (field does not get focused) #19812
Conversation
update branch 2.3 develop
…ab that owns the field (field does not get focused)
Hi @ravi-chandra3197. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
Hello @slavvka |
Hi @sivaschenko, thank you for the review. |
Hi @ravi-chandra3197 can you please squash this pull request to a single commit? (to remove unnecessary merge commits) |
Hi @ravi-chandra3197 I managed to remove the problematic merge commits from this pull request by changing base branch and changing it back. Looks like github issue |
Hello @sivaschenko |
Hi @ravi-chandra3197, thank you for your contribution! |
…g accordion tab that owns the field (field does not get focused) #19812
Hi @ravi-chandra3197. Thank you for your contribution. |
Hi @ravi-chandra3197, your fix works as expected when editing a product in the admin. I'm wondering if there is also a similar fix for the admin configuration page (admin/admin/system_config/). That section contains collapsibles also, and it'll be very helpful to have your fix implemented there also. Thanks, |
Description (*)
Fixed The ui-component field validation error not opening accordion tab that owns the field (field does not get focused)
Fixed Issues (if relevant)
Manual testing scenarios (*)
Contribution checklist (*)