Skip to content

[Backport 2.2] issue #18931 fixed. #19461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 31, 2019
Merged

[Backport 2.2] issue #18931 fixed. #19461

merged 1 commit into from
Jan 31, 2019

Conversation

@Jeroenll
Copy link
Member

@Jeroenll Jeroenll commented Nov 29, 2018 •
edited
Loading

Description (*)

Add missing translations, backport of #18938

Fixed Issues (if relevant)

  1. Product added to shopping cart / comparison list message not translated by default #18931: Product added to shopping cart / comparison list message not translated by default

Manual testing scenarios (*)

  1. Change language to non english.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

issue magento#18931 fixed.
3b521b0 
# Conflicts:
#	app/code/Magento/Catalog/i18n/en_US.csv
#	app/code/Magento/Checkout/i18n/en_US.csv
@Jeroenll Jeroenll added partners-contribution Pull Request is created by Magento Partner Partner: Reach Digital Pull Request is created by partner Reach Digital Partner: H&O Port labels Nov 29, 2018
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Nov 29, 2018

Hi @JeroenVanLeusden. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@Jeroenll Jeroenll mentioned this pull request Nov 29, 2018
Closed
@VladimirZaets VladimirZaets self-assigned this Nov 29, 2018
@magento-engcom-team magento-engcom-team added this to the Release: 2.2.8 milestone Nov 29, 2018
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Nov 29, 2018

Hi @VladimirZaets, thank you for the review.
ENGCOM-3593 has been created to process this Pull Request

@Jeroenll Jeroenll closed this Dec 12, 2018
@Jeroenll Jeroenll deleted the patch-1 branch December 12, 2018 14:39
@Jeroenll Jeroenll restored the patch-1 branch December 13, 2018 21:45
@Jeroenll Jeroenll reopened this Dec 13, 2018
@Jeroenll
Copy link
Member Author

Jeroenll commented Dec 13, 2018

@magento-engcom-team Accidentally deleted branch, did I mess up some automation tools now?

@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Jan 28, 2019

Hi @sidolov, thank you for the review.
ENGCOM-4003 has been created to process this Pull Request

@okorshenko okorshenko removed this from the Release: 2.2.8 milestone Jan 28, 2019
@magento-engcom-team magento-engcom-team mentioned this pull request Jan 31, 2019
Closed
@magento-engcom-team magento-engcom-team merged commit 3b521b0 into magento:2.2-develop Jan 31, 2019
@ghost
Copy link

ghost commented Jan 31, 2019

Hi @JeroenVanLeusden, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento-engcom-team pushed a commit that referenced this pull request Jan 31, 2019
@sidolov
ENGCOM-4003: [Backport 2.2] issue #18931 fixed. #19461
9a0806d
@magento-engcom-team magento-engcom-team added this to the Release: 2.2.8 milestone Jan 31, 2019
@Jeroenll Jeroenll deleted the patch-1 branch February 1, 2019 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@VladimirZaets VladimirZaets VladimirZaets approved these changes

@sidolov sidolov sidolov approved these changes

Assignees

@VladimirZaets VladimirZaets

@sidolov sidolov

Labels

Component: Catalog Component: Checkout Partner: H&O Partner: Reach Digital Pull Request is created by partner Reach Digital partners-contribution Pull Request is created by Magento Partner Release Line: 2.2

Projects

None yet

Milestone

Release: 2.2.8

Development

Successfully merging this pull request may close these issues.

5 participants

@Jeroenll @magento-engcom-team @VladimirZaets @sidolov @okorshenko