Skip to content

Multishipping Checkout Store id is saved NULL in sales_order_item Table: FIXED #19321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

mahesh-rajawat
Copy link
Member

During Multishipping Checkout Store Id is saving NULL in sales_order_item Table. Fixed in this PR.

Description (*)

I was fixing the Quote item id issue in this PR #19192 , found there is also Store id issue with Multishipping checkout. There was no store_id column in quote_address_item that's why
store_id values saved NULL. I have added store_id column in quote_address_item table in this PR.

Fixed Issues (if relevant)

Manual testing scenarios (*)

  1. After updating code i can check store_id saved correctly with Multishipping Checkout https://prnt.sc/llfjzv
  2. ...

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @maheshWebkul721. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team
Copy link
Contributor

Hi @sivaschenko, thank you for the review.
ENGCOM-3515 has been created to process this Pull Request

@@ -352,6 +352,8 @@
comment="Super Product Id"/>
<column xsi:type="int" name="parent_product_id" padding="10" unsigned="true" nullable="true" identity="false"
comment="Parent Product Id"/>
<column xsi:type="smallint" name="store_id" padding="5" unsigned="true" nullable="true" identity="false"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, we can't add a foreign key to store table due to Split database performance solution. This solution provides an ability to move quote related tables to a separate database and with current changes, we will have the fatal error due to missing table.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sidolov , foreign key removed

@mahesh-rajawat
Copy link
Member Author

@sidolov any update on it?

@sivaschenko
Copy link
Member

Thanks for the update @maheshWebkul721 ! We are continuing to process this pull request further.

@sivaschenko sivaschenko changed the base branch from 2.3-develop to 2.2-develop January 17, 2019 11:43
@sivaschenko sivaschenko changed the base branch from 2.2-develop to 2.3-develop January 17, 2019 11:43
…g-storeid-fix

# Conflicts:
#	app/code/Magento/Bundle/Model/Product/Type.php
@magento-engcom-team magento-engcom-team merged commit d708fa7 into magento:2.3-develop Jan 27, 2019
@ghost
Copy link

ghost commented Jan 27, 2019

Hi @maheshWebkul721, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento-engcom-team pushed a commit that referenced this pull request Jan 27, 2019
@magento-engcom-team
Copy link
Contributor

Hi @maheshWebkul721. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants