Skip to content

[Backport] Fix for #12399: Exception Error in Catalog Price Rule while Backend language is not English #19074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Mardl
Copy link
Contributor

@Mardl Mardl commented Nov 6, 2018

Original Pull Request
#18419

Fix for: #12399 cause it's not fixed in 2.2-develop

Description

I took the fix from #12399 (comment) cause it's almost identical code like
app/code/Magento/SalesRule/Controller/Adminhtml/Promo/Quote/Save.php:30

Fixed Issues (if relevant)

  1. Exception Error in Catalog Price Rule while Backend language is not English #12399 : Exception Error in Catalog Price Rule while Backend language is not English

Manual testing scenarios

https://youtu.be/xBMxMfKHmuc

  1. Go to: System -> All User -> [Choose your user]
  2. Change Interface Locale to Italien or French or Portuguese
  3. Relogin with this user
  4. Go to: Marketing -> catalog price rule
  5. Edit a record already created (or create a new)
  6. Set date From and/or To for example 20 Mai 2019 (Portuguese like "20/02/2019")
  7. Click on "Save and Apply"

PHP DateTime can not work with that format. Same problem in Promo/Quote/Save was fixed 2014 and 2016. Maybe forget to fix in Promo/Catalog/Save too.

Contribution checklist

  • [X ] Pull request has a meaningful description of its purpose
  • [X ] All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @Mardl. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me $VERSION instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@josefbehr josefbehr self-assigned this Nov 6, 2018
@magento-engcom-team magento-engcom-team added this to the Release: 2.2.8 milestone Nov 6, 2018
@magento-engcom-team
Copy link
Contributor

Hi @josefbehr, thank you for the review.
ENGCOM-3396 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

Hi @Mardl. Thank you for your contribution.
We will aim to release these changes as part of 2.2.8.
Please check the release notes for final confirmation.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

@Mardl
Copy link
Contributor Author

Mardl commented Nov 7, 2018

@magento-engcom-team this was just a backport from #18419 . It is already in 2.3-develop and will be in 2.3.1 release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants