Special price date from issue resolve

[hiren0241]

Fixed issue of 2.2.6 "Special price date from" Failed to parse time string

Description (*)

In magento 2.2.6 when Account locale set to it_IT and admin user create one new product and set it's special price then it will gives error while saving the product that failed to parse time string. In this Pull Request I have fixed this issue. By modifing date format before it's parse to Date object.

Fixed Issues (if relevant)

1. 2.2.6 "Special price date from" Failed to parse time string #18158: 2.2.6 "Special price date from" Failed to parse time string

Steps to reproduce

1. Magento 2.2.6 create a new product with a price
2. Edit the new product and add a special price

Expected result

1. The product has been saved

Actual result

1. DateTime::__construct(): Failed to parse time string (20/09/2018) at position 0 (2): Unexpected character

Manual testing scenarios (*)

1. Account locale set to it_IT if it's not set.
2. Add one new product and save. Than edit the product by adding special price and set from date as well. Press Save.
3. Product Save successfully that message will appear.
4. Now, Set another account locale and repeat the proceess, product will save successfully again.

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[magento-cicd2]

All committers have signed the CLA.

[magento-engcom-team]

Hi @hiren0241. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento-engcom-team give me test instance - deploy test instance based on PR changes
• @magento-engcom-team give me $VERSION instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

[larsroettig]

@magento-engcom-team give me test instance

[magento-engcom-team]

Hi @larsroettig. Thank you for your request. I'm working on Magento instance for you

[magento-engcom-team]

Hi @larsroettig, here is your new Magento instance.
Admin access: http://ec2-34-228-235-121.compute-1.amazonaws.com/pr-18578//admin
Login: admin Password: 123123q

[larsroettig]

@magento-engcom-team give me 2.3-develop instance

[magento-engcom-team]

Hi @larsroettig, thank you for the review.
ENGCOM-3184 has been created to process this Pull Request

[magento-engcom-team]

@hiren0241 thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

[magento-engcom-team]

Hi @hiren0241. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.