Skip to content

[Forwardport] #4942 and bundle checkbox bug #18520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

gelanivishal
Copy link
Contributor

@gelanivishal gelanivishal commented Oct 11, 2018

Original Pull Request

#15905

This fixes two bugs in relation to bundled products and a customer editing their selections in the cart.

Description

When a bundle item was edited after being in the cart, it was no different than loading the original product. There are two aspects to the fix:

  • Updating the JSON config to show the new quantities and selections
  • Adding selection array matching for checkboxes.

Fixed Issues (if relevant)

  1. On editing a Bundle product from shopping cart the user defined quantities of the options are overwritten #4942: On editing a Bundle product from shopping cart the user defined quantities of the options are overwritten

Manual testing scenarios

  1. Locate a bundled item with checkboxes
  2. Add that bundled item to the cart (with at least some checkboxes checked)
  3. Edit the item in the cart.
  4. Ensure that all items are checked and that the specified quantities match.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@sidolov
Copy link
Contributor

sidolov commented Oct 11, 2018

Hi @gelanivishal , please, add following commit to this port: eabe665
Thank you!

@gelanivishal
Copy link
Contributor Author

@sidolov Added.

@magento-engcom-team
Copy link
Contributor

Hi @sidolov, thank you for the review.
ENGCOM-3161 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

Hi @gelanivishal. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants