Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mass attribute update fails with E_WARNING #17592 #18068

Closed
wants to merge 1 commit into from
Closed

Mass attribute update fails with E_WARNING #17592 #18068

wants to merge 1 commit into from

Conversation

Dmutryk
Copy link

@Dmutryk Dmutryk commented Sep 15, 2018

Description

Fixed Issues (if relevant)

  1. Mass attribute update fails with E_WARNING #17592

Manual testing scenarios

  1. ...
  2. ...

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Sep 15, 2018

CLA assistant check
All committers have signed the CLA.

@magento-engcom-team
Copy link
Contributor

Hi @Dmutryk. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me $VERSION instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@rogyar
Copy link
Contributor

rogyar commented Sep 18, 2018

Hi @Dmutryk. Thank you for your contribution. Unfortunately, we cannot accept this change as it is. In some cases, the min_sale_qty default value is provided as an array. So, by removing the multiplier we face with an attempt to "echo" the array.
To avoid workarounds we need to investigate such scenarios and output the correct default value for min_sale_qty

@sidolov
Copy link
Contributor

sidolov commented Oct 2, 2018

Hi @Dmutryk , I am closing this PR now due to inactivity.
Please reopen and update if you wish to continue.
Thank you for the collaboration!

@sidolov sidolov closed this Oct 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants