Skip to content

Sales: Add unit test for validator model class #17876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 4, 2018
Merged

Sales: Add unit test for validator model class #17876

merged 2 commits into from
Sep 4, 2018

Conversation

@dmytro-ch
Copy link
Contributor

@dmytro-ch dmytro-ch commented Aug 31, 2018

Description

This PR adds missing unit test for:
\Magento\Sales\Model\Validator

Fixed Issues

N/A

Manual testing scenarios

N/A

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@dmytro-ch dmytro-ch requested a review from rogyar August 31, 2018 07:35
@magento-engcom-team magento-engcom-team added Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Component: Sales labels Aug 31, 2018
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Aug 31, 2018

Hi @dmytro-ch. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

rogyar
rogyar suggested changes Aug 31, 2018
View reviewed changes
app/code/Magento/Sales/Test/Unit/Model/ValidatorTest.php
$actual = $this->validator->validate($this->entityMock, $validators, $context);
$this->assertEquals($expected, $actual);
}

Copy link
Contributor

@rogyar rogyar Aug 31, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, remove the extra empty line

Copy link
Contributor Author

@dmytro-ch dmytro-ch Aug 31, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rogyar, thank you! I've fixed it.

@magento-engcom-team magento-engcom-team added this to the Release: 2.2.7 milestone Sep 2, 2018
@magento-engcom-team magento-engcom-team merged commit 0a205b2 into magento:2.2-develop Sep 4, 2018
magento-engcom-team pushed a commit that referenced this pull request Sep 4, 2018
ENGCOM-2907: Sales: Add unit test for validator model class #17876
5dc47da
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Sep 4, 2018

Hi @dmytro-ch. Thank you for your contribution.
We will aim to release these changes as part of 2.2.7.
Please check the release notes for final confirmation.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

This was referenced Sep 5, 2018
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@rogyar rogyar rogyar requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

@rogyar rogyar

Labels

Component: Sales Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.2

Projects

None yet

Milestone

Release: 2.2.7

Development

Successfully merging this pull request may close these issues.

3 participants

@dmytro-ch @magento-engcom-team @rogyar