Skip to content

[Forwardport] Making configurable settings for MAX_IMAGE_WIDTH and MAX_IMAGE_HEIGHT #17826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 13, 2018
Merged

[Forwardport] Making configurable settings for MAX_IMAGE_WIDTH and MAX_IMAGE_HEIGHT #17826

merged 2 commits into from
Sep 13, 2018

Conversation

nmalevanec
Copy link
Contributor

Original Pull Request

#15942

Description

It was added a new system fieldset, where the max-width and max-height can be set.
Stores / Configuration / Advanced / System / Images Configuration

So these 2 values are more flexible now for those which need to have bigger images in their shops.

Fixed Issues (if relevant)

  1. Wysiwyg > Image Uploader >Max width/height #13747: Wysiwyg > Image Uploader >Max width/height
  2. ...

Manual testing scenarios

  1. Get an image of 3000x700
    https://dummyimage.com/3000x700
  2. Open any wysiwyg editor
  3. Upload an image
  4. The uploaded image should have maximum configured size

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @nmalevanec. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@miguelbalparda miguelbalparda self-assigned this Aug 28, 2018
@magento-engcom-team
Copy link
Contributor

Hi @sidolov, thank you for the review.
ENGCOM-2955 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

Hi @nmalevanec. Thank you for your contribution.
We will aim to release these changes as part of 2.3.0.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants