Skip to content

[Backport] Fix Custom Attribute Group can not translate in catalog/product page #17684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 21, 2018
Merged

[Backport] Fix Custom Attribute Group can not translate in catalog/product page #17684

merged 1 commit into from
Aug 21, 2018

Conversation

dmytro-ch
Copy link
Contributor

@dmytro-ch dmytro-ch commented Aug 18, 2018 •
edited by sidolov
Loading

Original Pull Request

#17602

Description

Fix Custom Attribute Group can not translate in catalog/product page

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@dmytro-ch dmytro-ch requested a review from rogyar August 18, 2018 23:11
@magento-engcom-team magento-engcom-team added Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Component: Catalog Release Line: 2.1 labels Aug 18, 2018
@magento-engcom-team magento-engcom-team added this to the Release: 2.1.16 milestone Aug 19, 2018
@magento-engcom-team
Copy link
Contributor

Hi @sidolov, thank you for the review.
ENGCOM-2827 has been created to process this Pull Request

@magento-engcom-team magento-engcom-team merged commit 295c3b1 into magento:2.1-develop Aug 21, 2018
magento-engcom-team pushed a commit that referenced this pull request Aug 21, 2018
ENGCOM-2827: [Backport] Fix Custom Attribute Group can not translate …
5a60685 
…in catalog/product page #17684
@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch. Thank you for your contribution.
We will aim to release these changes as part of 2.1.16.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sidolov sidolov sidolov approved these changes

@rogyar rogyar Awaiting requested review from rogyar

Assignees

@rogyar rogyar

@sidolov sidolov

Labels
Component: Catalog Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.1
Projects
None yet
Milestone
Release: 2.1.16
Development

Successfully merging this pull request may close these issues.
4 participants
@dmytro-ch @magento-engcom-team @sidolov @rogyar