Skip to content

[Backport] Added unit test for newsletter problem model #17667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 20, 2018
Merged

[Backport] Added unit test for newsletter problem model #17667

merged 4 commits into from
Aug 20, 2018

Conversation

jignesh-baldha
Copy link
Member

Original Pull Request

#17633

Description

This PR adds unit test for \Magento\Newsletter\Model\Problem class.

Fixed Issues (if relevant)

N/A

Manual testing scenarios

N/A

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@sidolov
Copy link
Contributor

sidolov commented Aug 18, 2018

@jignesh-baldha , please, fix unit test according to used PHPUnit version

@jignesh-baldha
Copy link
Member Author

@sidolov Did changes according PHPUnit version.

@magento-engcom-team
Copy link
Contributor

Hi @jignesh-baldha. Thank you for your contribution.
We will aim to release these changes as part of 2.1.16.
Please check the release notes for final confirmation.

@jignesh-baldha jignesh-baldha deleted the 2.1-develop-PR-port-17633 branch August 27, 2018 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants