Skip to content

[Backport] Fix "Confirmation request" email is sent on customer's newsletter unsubscribe action #17347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

gelanivishal
Copy link
Contributor

Original Pull Request

#15464

Description

This fix related to #15218
Skip update customer subscribe status from save subscribe action from my account when nothing is changed.

Fixed Issues (if relevant)

  1. Skip update customer subscribe status from save subscribe action from my account when nothing is changed.

Manual testing scenarios

  1. Activate "Need to Confirm" for the newsletter subscription
  2. Register a new customer
  3. Subscribe to the newsletter
  4. Confirm the newsletter subscription.
  5. Login as created customer
  6. Unsubscribe from the newsletter from the customer area

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@sidolov
Copy link
Contributor

sidolov commented Aug 3, 2018

Hi @gelanivishal , please, take a look at failed tests

@sidolov
Copy link
Contributor

sidolov commented Aug 17, 2018

Hi @gelanivishal , I am closing this PR now due to inactivity.
Please reopen and update if you wish to continue.
Thank you for the collaboration!

@sidolov sidolov closed this Aug 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants