Skip to content

[Forwardport] 2.3 develop PR port 15942 #16277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

[Forwardport] 2.3 develop PR port 15942 #16277

wants to merge 3 commits into from

Conversation

eduard13
Copy link
Contributor

@eduard13 eduard13 commented Jun 20, 2018 •
edited by sidolov
Loading

Original Pull Request: #15942

Fixed Issues (if relevant)

  1. Wysiwyg > Image Uploader >Max width/height #13747: Wysiwyg > Image Uploader >Max width/height

Manual testing scenarios

Check the task's scenarios

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team magento-engcom-team added Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Area: Frontend Component: Backend Component: Cms labels Jun 20, 2018
@magento-engcom-team
Copy link
Contributor

Hi @eduard13. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on Pull Request changes
  • @magento-engcom-team give me new test instance - deploy NEW test instance based on Pull Request changes
  • @magento-engcom-team give me {$VERSION} instance - deploy Vanilla Magento instance for Issue or Pull Request

For more details, please, review the Magento Contributor Assistant documentation

@eduard13 eduard13 requested a review from rogyar June 20, 2018 20:27
@eduard13 eduard13 self-assigned this Jun 20, 2018
@eduard13 eduard13 changed the title [Forward] 2.3 develop PR port 15942 [Forwardport] 2.3 develop PR port 15942 Jun 20, 2018
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.0 milestone Jun 21, 2018
VladimirZaets
VladimirZaets reviewed Jun 25, 2018
View reviewed changes
app/code/Magento/Backend/Block/Media/Uploader.php Outdated
@@ -44,11 +51,13 @@ class Uploader extends \Magento\Backend\Block\Widget
public function __construct(
\Magento\Backend\Block\Template\Context $context,
\Magento\Framework\File\Size $fileSize,
\Magento\Framework\Image\Adapter\ConfigInterface $imageConfig,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @eduard13, due to Magento backward-compatible guide we can't add new required parameters to the constructor.

Please make this param optional, the example you can look here

VladimirZaets
VladimirZaets reviewed Jun 25, 2018
View reviewed changes
app/code/Magento/Backend/Block/Media/Uploader.php Outdated
/**
* @var \Magento\Framework\Image\Adapter\ConfigInterface
*/
protected $imageConfig;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Due to Magento backward-compatible guide we can't add protected properties. All new properties should be private.

@eduard13
Copy link
Contributor Author

@VladimirZaets thank you for the reviews. I've fixed them, moreover I've added also some other changes, which are fixing some modularity perspectives.
Also I'm not sure what should I do within the failing tests, can you please have a look and advice me something here?

@eduard13 eduard13 closed this Aug 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VladimirZaets VladimirZaets VladimirZaets left review comments

@rogyar rogyar Awaiting requested review from rogyar

Assignees

@VladimirZaets VladimirZaets

Labels
Area: Frontend Component: Backend Component: Cms Component: Framework/File Component: Framework/Image Component: MediaStorage Component: Theme Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Progress: needs update Progress: on hold Release Line: 2.3
Projects
None yet
Milestone
Release: 2.3.0
Development

Successfully merging this pull request may close these issues.
4 participants
@eduard13 @magento-engcom-team @VladimirZaets @orlangur