Skip to content

[Code improvement] #15792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

hitesh-wagento
Copy link
Contributor

This PR is a:

  • Bug fix or improvement

Summary

Added blank line after a selector.

Additional information

NA

@orlangur
Copy link
Contributor

orlangur commented Jun 5, 2018

Hi @hitesh-wagento, is such spacing recommended by https://devdocs.magento.com/guides/v2.2/coding-standards/code-standard-less.html? Feel free to add such changes into a single PR with LESS files indentation fix.

@hitesh-wagento
Copy link
Contributor Author

hitesh-wagento commented Jun 5, 2018

@orlangur have you rejected all my PRs ? Do I need to recreate all PRs ?

@orlangur
Copy link
Contributor

orlangur commented Jun 5, 2018

@hitesh-wagento there are one open for 2.2-develop and another for 2.3-develop left. Please put all needed changes in them.

@hitesh-wagento hitesh-wagento deleted the shipping-less-patch branch September 6, 2018 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Partner: Wagento Pull Request is created by partner Wagento partners-contribution Pull Request is created by Magento Partner Progress: reject
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants