Skip to content

[Forwardport] Wrong Last orders amount on dashboard #15660 #15676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

ankurvr
Copy link
Member

@ankurvr ankurvr commented Jun 2, 2018

Wrong order amount on dashboard on Last orders listing when having more than one website with different currencies #15660

Original Pull Request

#15536

Fixed Issues (if relevant)

  1. Wrong order amount on dashboard on Last orders listing when having more than one website with different currencies #15660: Wrong order amount on dashboard on Last orders listing when having more than one website with different currencies

Manual testing scenarios

  1. Create 2 Websites with 1 store in each
  2. Set Default website/store base currency as INR (Indian Rupee)
  3. Set another website/store base currency as USD (US Dollar)
  4. Place Order from both websites with with their default currencies.
  5. Now go to Dashboard and set Store View as All Store Views
  6. See Last Orders table and check order's total amounts and all mounts will be in INR (USD orders will be converted to INR with exchange rate
  7. Now change Store View to USD currency website's store which have orders
  8. See Last Orders table and check order's total amounts. You will find those amounts converted to again into INR to USD. But at this point orders are already in USD so no need to convert amounts

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

Wrong order amount on dashboard on Last orders listing when having more than one website with different currencies #15660
@magento-engcom-team
Copy link
Contributor

Hi @ankurvr

Unfortunately, we cannot accept Pull Requests from branches created in magento2 repository.
Please use your own fork as a base for this Pull Request.

Thank you.

@ankurvr ankurvr deleted the ankurvr-patch-2.3-develop branch June 2, 2018 04:16
@ankurvr ankurvr restored the ankurvr-patch-2.3-develop branch June 2, 2018 04:22
@ankurvr ankurvr reopened this Jun 2, 2018
@sidolov
Copy link
Contributor

sidolov commented Jun 2, 2018

Hi @ankurvr

Unfortunately, we cannot accept Pull Requests from branches created in magento2 repository.
Please use your own fork as a base for this Pull Request.

Thank you.

@sidolov sidolov closed this Jun 2, 2018
@sidolov sidolov deleted the ankurvr-patch-2.3-develop branch June 2, 2018 07:33
@ankurvr
Copy link
Member Author

ankurvr commented Jun 2, 2018

@sidolov I am sorry for the wrong branch pull request. I have created another pull request with same fixes from my repo #15682

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants