Skip to content

Fixed Responsive Design, Footers bottom of screen on mobile devices #… #15471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Fixed Responsive Design, Footers bottom of screen on mobile devices #… #15471

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b377748
Fixed Responsive Design, Footers bottom of screen on mobile devices #…
chirag-wagento May 24, 2018
289ad26
Merge remote-tracking branch 'origin/2.2-develop' into responsive-des…
chirag-wagento May 30, 2018
8139013
Responsive Design, Footers screen on mobile devices #15118
chirag-wagento May 30, 2018
56d9405
Responsive Design, Footers screen on mobile #15118
chirag-wagento May 30, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 20 additions & 6 deletions app/design/frontend/Magento/luma/Magento_Theme/web/css/source/_module.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -362,6 +362,26 @@
// _____________________________________________

.media-width(@extremum, @break) when (@extremum = 'max') and (@break = @screen__m) {
html,
body {
height: 100%; // Stretch screen area for sticky footer
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use height: 100% is a bad practice because content can be more than 100% and in this case, body block will not adaptive to content, it will be always 100% independent to content, that's is wrong.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@VladimirZaets
I have checked with content and without content page I don't see any issue .

Can you see attached image.
If still you have any query then you attach issue screen shot. I will try to solve
with-content
without-content png

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But in Safari and other browsers and cases. 'min-height: 100%` should be used.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DanielRuf
I have checked with 'min-height'.
If i will use 'min-height' then I can see some responsive issue. You can see attached
One more important thing there are use 'height: 100%' for desktop view.
I have checked in chrome, firefox and safari.

Right now I can't see any issue If you can see any isseu then please atteched screen short.
I will check it

mini-h

Thanks

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If i will use 'min-height' then I can see some responsive issue.

Please elaborate what issue you see.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After add 'min-height:100% you can see issue in screenshot ' footer is not touch in bottom.

}
header,
main,
footer {
flex-shrink: 0;
}
.page-wrapper {
.lib-vendor-prefix-display(flex);
.lib-vendor-prefix-flex-direction(column);
align-items: stretch;
-webkit-align-items: stretch;
min-height: 100%; // Stretch content area for sticky footer
.page-main {
flex-grow: 1;
-webkit-flex-grow: 1;
}
}
.customer-name,
.customer-welcome + .authorization-link {
display: none;
Expand Down Expand Up @@ -418,12 +438,6 @@
}
}
}
.page-footer,
.copyright {
bottom: 0;
position: absolute;
width: 100%;
}
}

.media-width(@extremum, @break) when (@extremum = 'max') and (@break = @screen__s) {
Expand Down