Skip to content

Removed duplicate line and added comment on variable #15362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 22, 2018
Merged

Removed duplicate line and added comment on variable #15362

merged 2 commits into from
May 22, 2018

Conversation

gelanivishal
Copy link
Contributor

@gelanivishal gelanivishal commented May 19, 2018 •
edited
Loading

Description

Removed duplicate code and added comment on variable.

Fixed Issues (if relevant)

  1. N/A

Manual testing scenarios

  1. N/A

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@mzeis mzeis self-assigned this May 19, 2018
@mzeis
Copy link
Contributor

mzeis commented May 19, 2018

Hi @vgelani, thank you for your PR!

I would say we can also remove the second comment $_template line. What do you think?

@gelanivishal
Copy link
Contributor Author

@mzeis Yes. I also think about it. Let me remove it.

@gelanivishal gelanivishal requested a review from okorshenko May 19, 2018 14:59
@magento-engcom-team magento-engcom-team added this to the May 2018 milestone May 19, 2018
@magento-engcom-team
Copy link
Contributor

Hi @mzeis, thank you for the review.
ENGCOM-1592 has been created to process this Pull Request

magento-team pushed a commit that referenced this pull request May 22, 2018
@VladimirZaets
ENGCOM-1592: Removed duplicate line and added comment on variable #15362
85df843
@magento-engcom-team magento-engcom-team merged commit ff9bf03 into magento:2.2-develop May 22, 2018
@magento-engcom-team
Copy link
Contributor

Hi @vgelani. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.2.5 release.

Please, consider porting this solution across release lines.
You may use Porting tool to port commits automatically.

This was referenced May 23, 2018
Merged
Merged
This was referenced Jun 14, 2018
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mzeis mzeis mzeis approved these changes

@okorshenko okorshenko Awaiting requested review from okorshenko

Assignees

@mzeis mzeis

Labels
Component: Sales Event: dmcdindia improvement Progress: accept Release Line: 2.2
Projects
None yet
Milestone
May 2018
Development

Successfully merging this pull request may close these issues.
3 participants
@gelanivishal @mzeis @magento-engcom-team