Skip to content

Added language translation for message string #15333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 22, 2018
Merged

Added language translation for message string #15333

merged 4 commits into from
May 22, 2018

Conversation

yogeshsuhagiya
Copy link
Member

Description

Added language translation for message string

Fixed Issues (if relevant)

  1. N/A

Manual testing scenarios

  1. N/A

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@mzeis mzeis self-assigned this May 19, 2018
@mzeis
Copy link
Contributor

mzeis commented May 19, 2018

Hi @yogeshks, thank you very much for this PR! Please can you add the translation string to the CSV file of the module? Thanks!

@yogeshsuhagiya
Copy link
Member Author

Hello @mzeis
I've added the translation string to the CSV file, please verify it.

@mzeis
Copy link
Contributor

mzeis commented May 20, 2018

Hi @yogeshks, thank you very much!

@magento-engcom-team magento-engcom-team added this to the May 2018 milestone May 20, 2018
@magento-engcom-team
Copy link
Contributor

Hi @mzeis, thank you for the review.
ENGCOM-1609 has been created to process this Pull Request

@amittiwari024 amittiwari024 requested review from amittiwari024 and removed request for amittiwari024 May 21, 2018 14:16
magento-team pushed a commit that referenced this pull request May 22, 2018
@VladimirZaets
ENGCOM-1609: Added language translation for message string #15333
7a6149b
@magento-engcom-team magento-engcom-team merged commit 0dc700b into magento:2.2-develop May 22, 2018
@magento-engcom-team
Copy link
Contributor

Hi @yogeshks. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.2.5 release.

Please, consider porting this solution across release lines.
You may use Porting tool to port commits automatically.

This was referenced May 22, 2018
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mzeis mzeis mzeis approved these changes

Assignees

@mzeis mzeis

Labels
bugfix Event: dmcdindia Progress: accept Release Line: 2.2
Projects
None yet
Milestone
May 2018
Development

Successfully merging this pull request may close these issues.
3 participants
@yogeshsuhagiya @mzeis @magento-engcom-team