Skip to content

Fix \Magento\Customer\Model\Customer\NotificationStorage class #15262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

adrian-martinez-interactiv4
Copy link
Contributor

Fix \Magento\Customer\Model\Customer\NotificationStorage class

Description

Removed duplicated phpdoc comment
Fixed class variable phpdoc comment
Removed deprecated private method getSerializer, serializer injected in constructor instead

Fixed Issues (if relevant)

None, improvement.

Manual testing scenarios

None, improvement.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

Fix class variable phpdoc comment
Remove deprecated private method getSerializer, injected in constructor instead
@magento-engcom-team
Copy link
Contributor

Hi @adrian-martinez-interactiv4. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.2.5 release.

Please, consider porting this solution across release lines.
You may use Porting tool to port commits automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Partner: Interactiv4 Pull Request is created by partner Interactiv4 partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants