Skip to content

Add expanded documentation to AdapterInterface::update #14755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 20, 2018
Merged

Add expanded documentation to AdapterInterface::update #14755

merged 1 commit into from
Apr 20, 2018

Conversation

navarr
Copy link
Member

@navarr navarr commented Apr 18, 2018

This adds a long description to AdapterInterface::update detailing how the $where parameter works

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@navarr
Add expanded documentation to AdapterInterface::update
239f240 
This adds a long description to AdapterInterface::update detailing how the `$where` parameter works
@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Apr 18, 2018 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@navarr navarr changed the base branch from 2.2-develop to 2.3-develop April 18, 2018 12:33
@magento-engcom-team magento-engcom-team added this to the April 2018 milestone Apr 18, 2018
@dmanners
Copy link
Contributor

Hi @navarr thank you for this PR. I will process this now for you.

@dmanners
Copy link
Contributor

Hi @navarr I am having a few issues with the branch. Is this branch up to date with the latest 2.3-develop branch?

@navarr
Copy link
Member Author

navarr commented Apr 18, 2018

@dmanners Yes. This branch is based off commit f5debf0 which is the latest in the 2.3-develop branch.

This was referenced Apr 19, 2018
Closed
Closed
Merged
Merged
@magento-engcom-team magento-engcom-team merged commit 239f240 into magento:2.3-develop Apr 20, 2018
magento-engcom-team pushed a commit that referenced this pull request Apr 20, 2018
ENGCOM-1318: Add expanded documentation to AdapterInterface::update #…
e400817 
…14755
@magento-engcom-team
Copy link
Contributor

Hi @navarr. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.3.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@dmanners dmanners

Labels
Progress: accept Release Line: 2.3
Projects
None yet
Milestone
April 2018
Development

Successfully merging this pull request may close these issues.
4 participants
@navarr @magento-cicd2 @dmanners @magento-engcom-team