Validate that the PO Number is set on the payment instance. #14393
Conversation
|
|
| parent::validate(); | ||
|
|
||
| if (empty($this->getInfoInstance()->getPoNumber())) { | ||
| throw new LocalizedException(__('Purchase order number is a required field.')); |
There was a problem hiding this comment.
Can you add this string to the .csv so it can be translated?
There was a problem hiding this comment.
Thanks @miguelbalparda ! I totally forgot about this 🤦♂️
| parent::validate(); | ||
|
|
||
| if (empty($this->getInfoInstance()->getPoNumber())) { | ||
| throw new LocalizedException(__('Purchase order number is a required field.')); |
|
Hi @miguelbalparda, thank you for the review. |
|
Hi @centerax. Thank you for your contribution. Please, consider to port this solution to 2.3 release line. |
|
This is a bad "fix". When did Magento decide that PO# is always required on the payment instance? That should be set by configuration, not hard-coded. |
|
I'm not that sure @dnadle, care to expand your comment? If you really think this shouldn't be in the core feel free to submit your patch with an explanation and assign it to me for review. |
The validation is performed only on the payment method Purchaseorder. I dont see how its a global validation for all payment methods as you seem to imply. |
|
OK, I take it back. We had a payment mode in production where the purchase order payment method was used with optional PO #, that was working through 2.2.6. An upgrade to 2.2.9 with this check surprised us. Sorry for the confusion. |
|
Np thanks for keeping this civilized. |
|
The bug still exists on Magneto version 2.4.1
Root cause: purchase order number is not sent to server.
|
Description
Validate that the
po_numberis set on the info instance.Fixed Issues (if relevant)
Manual testing scenarios
Contribution checklist