-
Notifications
You must be signed in to change notification settings - Fork 9.4k
[Forward Port 2.3] Increase flag_data size #13580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Forward Port 2.3] Increase flag_data size #13580
Conversation
Increase flag_data size from 64k to 16m to support bigger config dumps.
@aschrammel , original pull request was closed due to inactivity, if you wish to continue, please, fix and reopen original pull request and apply fixes to port. |
Hi @aschrammel. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
Hi @orlangur, thank you for the review.
|
@magento run all tests |
Hi @aschrammel, thank you for your contribution! |
Will this be backported to 2.2? |
@jeff-jk nothing will be backported to 2.2 afaik, it is closed for contribution. |
Thanks for clarifying @orlangur |
This PR is a forward port of PR #13579
The flag_data field in the flag table is too small to reimport a config generated by bin/magento app:config:dump with more than 64KB size.
Increasing this field should be considered, as exporting the config and reimporting it is the suggested way for pipeline deployment.
Description
If a bin/magento app:config:dump produces a config.php with more than 64KB of size, the bin/magento app:config:import or bin/magento setup:upgrade will fail because of the TEXT field limitation from flag_data in the flag table.
This PR increases the flag_data field to MEDIUMTEXT accepting 16MB.
Fixed Issues (if relevant)
#11657: app:config:import fails - flag column 'flag_data' is too short ?
Manual testing scenarios
Run bin/magento setup:install
Before applying the PR, the flag_data field is a TEXT field accepting 64KB
After applying the PR, the flag_data field is a MEDIUMTEXT field accepting 16MB
Contribution checklist