Skip to content

[Forward Port 2.3] Increase flag_data size #13580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 16, 2019

Conversation

aschrammel
Copy link

This PR is a forward port of PR #13579

The flag_data field in the flag table is too small to reimport a config generated by bin/magento app:config:dump with more than 64KB size.
Increasing this field should be considered, as exporting the config and reimporting it is the suggested way for pipeline deployment.

Description

If a bin/magento app:config:dump produces a config.php with more than 64KB of size, the bin/magento app:config:import or bin/magento setup:upgrade will fail because of the TEXT field limitation from flag_data in the flag table.

This PR increases the flag_data field to MEDIUMTEXT accepting 16MB.

Fixed Issues (if relevant)

#11657: app:config:import fails - flag column 'flag_data' is too short ?
Manual testing scenarios
Run bin/magento setup:install
Before applying the PR, the flag_data field is a TEXT field accepting 64KB
After applying the PR, the flag_data field is a MEDIUMTEXT field accepting 16MB

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

Increase flag_data size from 64k to 16m to support bigger config dumps.
@orlangur orlangur self-assigned this Feb 12, 2018
@orlangur orlangur changed the title [Forward Port 2.2.3] Increase flag_data size [Forward Port 2.3] Increase flag_data size Feb 13, 2018
@sidolov sidolov self-assigned this May 14, 2018
@sidolov
Copy link
Contributor

sidolov commented May 14, 2018

@aschrammel , original pull request was closed due to inactivity, if you wish to continue, please, fix and reopen original pull request and apply fixes to port.
Thank you for collaboration!

@sidolov sidolov closed this May 14, 2018
@aschrammel aschrammel mentioned this pull request Jul 12, 2018
4 tasks
@orlangur orlangur reopened this Jul 31, 2019
@m2-assistant
Copy link

m2-assistant bot commented Jul 31, 2019

Hi @aschrammel. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@ghost ghost unassigned orlangur and sidolov Jul 31, 2019
@magento-engcom-team
Copy link
Contributor

Hi @orlangur, thank you for the review.
ENGCOM-5524 has been created to process this Pull Request
✳️ @orlangur, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@orlangur orlangur added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Jul 31, 2019
@engcom-Alfa engcom-Alfa self-assigned this Jul 31, 2019
@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

Before:

before

After:

after

@engcom-Foxtrot
Copy link
Contributor

@magento run all tests

@m2-assistant
Copy link

m2-assistant bot commented Aug 16, 2019

Hi @aschrammel, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.4 milestone Aug 16, 2019
@jeff-jk
Copy link

jeff-jk commented Aug 29, 2019

Will this be backported to 2.2?

@orlangur
Copy link
Contributor

@jeff-jk nothing will be backported to 2.2 afaik, it is closed for contribution.

@jeff-jk
Copy link

jeff-jk commented Aug 30, 2019

Thanks for clarifying @orlangur

@aschrammel aschrammel deleted the flag_data branch February 4, 2020 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Component: Setup Progress: accept Release Line: 2.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants