Skip to content

Switch updatecart qty input validators to dynamic instead of hardcoding #13462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 9, 2018
Merged

Switch updatecart qty input validators to dynamic instead of hardcoding #13462

merged 1 commit into from
Feb 9, 2018

Conversation

gil--
Copy link
Member

@gil-- gil-- commented Feb 1, 2018

Description

Currently, the edit cart product input has hardcoded validators which differ from the main PDP page. What is the reasoning for this? This prevents custom qty validators applied on normal PDP from applying when you update said product qty.

updateCart.phtml vs addtocart.phtml

This PR matches both updatecart.phtml and addtocart.phtml qty input validators. Now when you target, afterGetQuantityValidators it will apply to both inputs.

Maybe I am mistaken and there is a real reason they did not originally match?

Manual testing scenarios

  1. Check DOM to see outputted validators on PDP and on PDP edit.
  2. Both will match.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@rogyar rogyar self-assigned this Feb 5, 2018
@rogyar rogyar added this to the February 2018 milestone Feb 6, 2018
@magento-engcom-team
Copy link
Contributor

@gil-- thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants