Fix jumping content on page reload in admin area #12985
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For thousands of years in the ancient history of Magento 2, Magento admin and developers, working in the admin area have been annoyed by jumping page content when they load or reload a page and a system message is available.
This PR is intended to take this burden from anyone working in the Magento 2 admin area and to live happily ever after.
Description
This PR sets a min-height on the notices-wrapper, causing the page not to jump any more. See also this video i've created (before/after): https://www.youtube.com/watch?v=btPogRyFP98.
Fyi: The
min-height: 5rem
was duplicated from the child element.message-system-short
.Fixed Issues (if relevant)
No issues known or found.
Manual testing scenarios
Given that there is any system notice that Magento 2 is showing (indexer or cache needs to be renewed, tax settings wrong, etc.)
Contribution checklist