Skip to content

Fix jumping content on page reload in admin area #12985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 9, 2018
Merged

Fix jumping content on page reload in admin area #12985

merged 1 commit into from
Jan 9, 2018

Conversation

avoelkl
Copy link
Contributor

@avoelkl avoelkl commented Jan 4, 2018

For thousands of years in the ancient history of Magento 2, Magento admin and developers, working in the admin area have been annoyed by jumping page content when they load or reload a page and a system message is available.
This PR is intended to take this burden from anyone working in the Magento 2 admin area and to live happily ever after.

Description

This PR sets a min-height on the notices-wrapper, causing the page not to jump any more. See also this video i've created (before/after): https://www.youtube.com/watch?v=btPogRyFP98.
Fyi: The min-height: 5rem was duplicated from the child element .message-system-short.

Fixed Issues (if relevant)

No issues known or found.

Manual testing scenarios

Given that there is any system notice that Magento 2 is showing (indexer or cache needs to be renewed, tax settings wrong, etc.)

  1. Open any page in the magento admin area
  2. Load or reload page
  3. See that the content is loaded
  4. As soon as the system messages on top of the page are loaded, the content jumps 3rem/5px down

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@avoelkl avoelkl changed the title Fix jumping content on page reload in admin area [2.2-develop] Fix jumping content on page reload in admin area Jan 4, 2018
@avoelkl avoelkl changed the title [2.2-develop] Fix jumping content on page reload in admin area Fix jumping content on page reload in admin area Jan 4, 2018
@osrecio osrecio self-requested a review January 4, 2018 17:11
@osrecio osrecio self-assigned this Jan 4, 2018
@osrecio osrecio removed their request for review January 4, 2018 17:13
@osrecio
Copy link
Member

osrecio commented Jan 9, 2018

Hi @avoelkl Thanks for your contribution, and sorry for my delay!

I'm working to process your PR 😄

@osrecio osrecio added this to the January 2018 milestone Jan 9, 2018
@osrecio osrecio requested review from osrecio and removed request for osrecio January 9, 2018 12:15
@magento-team magento-team merged commit c3943ec into magento:2.2-develop Jan 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants