Skip to content

[Backport to 2.1-develop] Fix #2156 Js\Dataprovider uses the RendererInterface. #12954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 11, 2018
Merged

[Backport to 2.1-develop] Fix #2156 Js\Dataprovider uses the RendererInterface. #12954

merged 3 commits into from
Jan 11, 2018

Conversation

dverkade
Copy link
Member

@dverkade dverkade commented Jan 2, 2018

Description

Backport

  1. Backport of Fix #2156 Js\Dataprovider uses the RendererInterface. #12007

Fixed Issues

  1. Why does \Magento\Translation\Model\Js\DataProvider use \Magento\Framework\Phrase\Renderer\Translate, not \Magento\Framework\Phrase\Renderer\Composite? #2156: Why does \Magento\Translation\Model\Js\DataProvider use \Magento\Framework\Phrase\Renderer\Translate, not \Magento\Framework\Phrase\Renderer\Composite?

@dverkade
- Fix #2156 changed dataprovider constructor to the RendererInterface
65c99b9 
- Changed InlineTest, which has an Inline class object and not a Translate class object
@dverkade dverkade changed the title [Backport to 2.2-develop] Fix #2156 Js\Dataprovider uses the RendererInterface. [Backport to 2.1-develop] Fix #2156 Js\Dataprovider uses the RendererInterface. Jan 2, 2018
@magento-engcom-team magento-engcom-team added bugfix Fixed in 2.3.x The issue has been fixed in 2.3 release line Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release TECH labels Jan 2, 2018
@dmanners dmanners self-assigned this Jan 3, 2018
@dmanners dmanners added this to the January 2018 milestone Jan 3, 2018
@magento-engcom-team magento-engcom-team added the Fixed in 2.2.x The issue has been fixed in 2.2 release line label Jan 9, 2018
@magento-team magento-team mentioned this pull request Jan 11, 2018
Closed
@magento-team magento-team merged commit a0b7bc5 into magento:2.1-develop Jan 11, 2018
magento-team pushed a commit that referenced this pull request Jan 11, 2018
MAGETWO-86285: [Backport to 2.1-develop] Fix #2156 Js\Dataprovider us…
4a98c46 
…es the RendererInterface. #12954
@magento-engcom-team magento-engcom-team added the Fixed in 2.1.x The issue has been fixed in 2.1 release line label Jan 11, 2018
@dverkade dverkade deleted the 2.1-Fix-Js-Dataprovider-uses-the-RendererInterface branch June 22, 2018 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@dmanners dmanners

Labels
bugfix Community Insider: Cream community-insider-contribution Fixed in 2.1.x The issue has been fixed in 2.1 release line Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Progress: accept Release Line: 2.1 Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Milestone
January 2018
Development

Successfully merging this pull request may close these issues.
4 participants
@dverkade @magento-team @dmanners @magento-engcom-team