Update checkout controller json usage #12806
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nager and use the result factory instead
… addExceptionMessage rather than the deprecated addException
…e object manager mocking
mzeis
suggested changes
Dec 20, 2017
| ->with(100) | ||
| ->will($this->returnValue($customer)); | ||
|
|
||
| $resultJson = '{"errors": "false", "message": "A letter with further instructions will be sent to your email."}'; |
There was a problem hiding this comment.
@dmanners Please can you split this up so the line doesn't exceed 120 characters? I'd do it myself but my VM pretends to by dying atm so I cannot run my tests locally sigh. ;)
There was a problem hiding this comment.
sure I can sort that out today
|
@mzeis updated from your feedback. |
mzeis
approved these changes
Dec 21, 2017
|
Thank you very much for your contribution, the change will be merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The controller
app/code/Magento/Checkout/Controller/Account/Create.phpuses the object manager directly when building it's json response. I have replaced the usage of object manager with the usage of$this->resultFactory->create(ResultFactory::TYPE_JSON);Manual testing scenarios
Contribution checklist