Skip to content

fix for syntax error in function list #1147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

fix for syntax error in function list #1147

wants to merge 3 commits into from

Conversation

marcinfr
Copy link

  • fix for syntax error in function list

@vpelipenko
Copy link
Contributor

@marcinfr, what is your decision about this fix? Change was done and then reverted.

@marcinfr
Copy link
Author

Change should be applied, fix is done.

@orlangur
Copy link
Contributor

orlangur commented Apr 2, 2015

I don't see any syntax error in changed code, see example in PHP documentation.

As a result of this change first element of array is assigned to variable, not a second one. System behavior breakage was revealed by integration test.

@marcinfr marcinfr closed this Apr 2, 2015
@marcinfr marcinfr deleted the feature-fix_syntax_error_in_list_funtion_in_ProductUrlRewriteGenerator branch April 10, 2015 14:10
magento-engcom-team pushed a commit that referenced this pull request Feb 2, 2018
MAGETWO-87339: #7849: M2.x.x Translation Missing in Checkout for Tax #…
4ea8640 
…1147

 - Merge Pull Request magento-engcom/magento2ce#1147 from RomaKis/magento2:7849
 - Merged commits:
   1. 4d02b99
magento-engcom-team pushed a commit that referenced this pull request Feb 2, 2018
MAGETWO-87339: #7849: M2.x.x Translation Missing in Checkout for Tax #…
9ccfccb 
…1147
VitaliyBoyko pushed a commit to VitaliyBoyko/magento2 that referenced this pull request Jun 22, 2018
Merge pull request magento#1147 from magento-engcom/1115_default_sour…
9b11fc8 
…ce_prevent_disabling

MSI-1115: Created validator for default Source Code. Should be enabled
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug report Progress: needs update
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marcinfr @vpelipenko @orlangur