Translation of validation messages

[maximehuran]

Preconditions

Magento Version is 2.1.3

Steps to reproduce

1. Call a validation message in lib/web/mage/validation.js

Expected result

1. Have a translated string

Actual result

1. No translation

I change :

"validate-email": [
            function (v) {
                return $.mage.isEmptyNoTrim(v) || /^([a-z0-9,!\#\$%&'\*\+\/=\?\^_`\{\|\}~-]|[\u00A0-\uD7FF\uF900-\uFDCF\uFDF0-\uFFEF])+(\.([a-z0-9,!\#\$%&'\*\+\/=\?\^_`\{\|\}~-]|[\u00A0-\uD7FF\uF900-\uFDCF\uFDF0-\uFFEF])+)*@([a-z0-9-]|[\u00A0-\uD7FF\uF900-\uFDCF\uFDF0-\uFFEF])+(\.([a-z0-9-]|[\u00A0-\uD7FF\uF900-\uFDCF\uFDF0-\uFFEF])+)*\.(([a-z]|[\u00A0-\uD7FF\uF900-\uFDCF\uFDF0-\uFFEF]){2,})$/i.test(v);
            },
            'Please enter a valid email address (Ex: johndoe@domain.com).'
        ],

To :

"validate-email": [
            function (v) {
                return $.mage.isEmptyNoTrim(v) || /^([a-z0-9,!\#\$%&'\*\+\/=\?\^_`\{\|\}~-]|[\u00A0-\uD7FF\uF900-\uFDCF\uFDF0-\uFFEF])+(\.([a-z0-9,!\#\$%&'\*\+\/=\?\^_`\{\|\}~-]|[\u00A0-\uD7FF\uF900-\uFDCF\uFDF0-\uFFEF])+)*@([a-z0-9-]|[\u00A0-\uD7FF\uF900-\uFDCF\uFDF0-\uFFEF])+(\.([a-z0-9-]|[\u00A0-\uD7FF\uF900-\uFDCF\uFDF0-\uFFEF])+)*\.(([a-z]|[\u00A0-\uD7FF\uF900-\uFDCF\uFDF0-\uFFEF]){2,})$/i.test(v);
            },
            $.mage.__('Please enter a valid email address (Ex: johndoe@domain.com).')
        ],

My modification is :
$.mage.__('Please enter a valid email address (Ex: johndoe@domain.com).')

And it works !

[veloraven]

@maximehuran thank you for your report.
Please, also identify which version of Magento you are running.

[maximehuran]

Magento Version is 2.1.3 Le mer. 18 janv. 2017 à 16:20, Olga Moyseyenko <notifications@github.com> a écrit :

…

@maximehuran <https://github.com/maximehuran> thank you for your report. Please, also identify which version of Magento you are running. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#8179 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AK2nkz2ncVS8CZP72TfYmEj5_7EIAq8sks5rTi21gaJpZM4Lm6h8> .

[quienti]

Already fixed in develop branch => https://github.com/magento/magento2/blob/develop/lib/web/mage/validation.js#L496

Commit => 3109c8e

So, probably fixed in Magento 2.2

[KrystynaKabannyk]

Internal ticket MAGETWO-61566

[Triloworld]

Thanks for that fix. I think is incomplete. Better approach:

Function in validation.js:
$.validator.addMethod

add this line:
$.validator.messages[name] = $.mage.__($.validator.messages[name]);

It will by default translate all built-in and new validation method.