Skip to content

Filesystem Https driver does not work with https:// links #720

Closed
@mszterlingfsite

Description

@mszterlingfsite

If you specify link as https://domain.com/path/to/file.zip
Magento\Framework\Filesystem\Driver\Https which extends Magento\Framework\Filesystem\Driver\Http
will not create the stream correctly

https://github.com/magento/magento2/blob/master/lib/internal/Magento/Framework/Filesystem/Driver/Http.php
in fileOpen() method $port will always be 80

$parse = parse_url('https://domain.com/path/to/file.zip');
var_dump($parse);

returns

array(3) {
  ["scheme"]=>
  string(5) "https"
  ["host"]=>
  string(10) "domain.com"
  ["path"]=>
  string(17) "/path/to/file.zip"
}

so in above case @fsockopen($hostname, $port, $errorNumber, $errorMessage); will have incorrect hostname and port

For SSL $hostname should be ssl://domain.com and $port should be 443

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions