Few weaknesses in the code #6715
Description
Hi!
I hope this will be helpful:
app/code/Magento/Usps/Model/Carrier.php
if ($response === false || $response->getName() == 'Error') {
$debugData['result'] = [
'error' => $response->Description,
'code' => $response->Number,
'xml' => $response->asXML(),
];
...
}
if $response is false, method asXML will be called on false
app/code/Magento/CatalogSearch/Model/Layer/Filter/Decimal.php
$label = $this->renderRangeLabel(
empty($from) ? 0 : $from,
empty($to) ? $to : $to
);
Both parts of ternary operators are equals.
app/code/Magento/CatalogRule/Model/Rule.php
if (is_array($value)) {
if ($value != $array2[$key]) {
$result[$key] = true;
}
} else {
if ($value != $array2[$key]) {
$result[$key] = true;
}
}
Parts of if-conditional operator are equals.
Possible defect was found by Echelon team with AppChecker static analyzer