Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WebAPI Bug] Customer can change disable_auto_group_change attribure at /V1/customers/me #39240

Open
2 of 5 tasks
wubinworks opened this issue Oct 7, 2024 · 4 comments
Open
2 of 5 tasks
Assignees

Comments

@wubinworks
Copy link

wubinworks commented Oct 7, 2024

Preconditions and environment

  • Magento 2.4.7 Community Edition
  • Register a customer for reproduce if needed

Steps to reproduce

  1. Generate <CUSTOMER TOKEN> as described in office document.
  2. Confirm customer data:
curl --request GET 'https://<domain>/rest/V1/customers/me' \
    --header 'Authorization: Bearer <CUSTOMER TOKEN>'

Output body:
{
    "id": 1,
    "email": "user@example.com",
    "firstname":"Firstname",
    "lastname":"Lastname",
    ...
    "disable_auto_group_change": 0,
    "created_in": "Default Store View",
    "extension_attributes": {
        "is_subscribed": false
    }
    ...
}
  1. Change customer data:
curl --request PUT 'https://<domain>/rest/V1/customers/me' \
    --header 'Authorization: Bearer <CUSTOMER TOKEN>' \
    --header 'Content-Type: application/json' \
    --data-raw '{
        "customer": {
            "id": 1,
            "email": "user@example.com",
            "firstname":"Firstname",
            "lastname":"Lastname",
            "disable_auto_group_change": 1,
            "created_in": "Changed",
            "confirmation": "Hello",
            "extension_attributes": {
                "is_subscribed": true
            }
        }
    }'
  1. Confirm customer data again:
curl --request GET 'https://<domain>/rest/V1/customers/me' \
    --header 'Authorization: Bearer <CUSTOMER TOKEN>'

Output body:
{
    "id": 1,
    "email": "user@example.com",
    "firstname":"Firstname",
    "lastname":"Lastname",
    ...
    "disable_auto_group_change": 1,
    "created_in": "Changed",
    "confirmation": "Hello",
    "extension_attributes": {
        "is_subscribed": true
    }
    ...
}

Expected result

At least disable_auto_group_change and confirmation should not be changed.
Maybe Magento WebAPI needs to throw exception.

Actual result

Both disable_auto_group_change, created_in, confirmation and extension_attributes.is_subscribed is editable in Customer User Context.

disable_auto_group_change checkbox change can be confirmed on Admin Panel.

Additional information

disable_auto_group_change: it should only be changeable by Admin or Integration.
created_in: this attribute is set during registration but not used elsewhere.
confirmation: it should only be changeable by Admin or Integration.
extension_attributes.is_subscribed: this one should only be changeable by unsubscribe link?

Additional:
disable_auto_group_change and confirmation should not be visible in Customer User Context WebAPI output.

Release note

No response

Triage and priority

  • Severity: S0 - Affects critical data or functionality and leaves users without workaround.
  • Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
  • Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
  • Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
  • Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.
Copy link

m2-assistant bot commented Oct 7, 2024

Hi @wubinworks. Thank you for your report.
To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce.


Join Magento Community Engineering Slack and ask your questions in #github channel.
⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.
🕙 You can find the schedule on the Magento Community Calendar page.
📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

Copy link

m2-assistant bot commented Oct 7, 2024

Hi @engcom-Bravo. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
  • 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
  • 4. Verify that the issue is reproducible on 2.4-develop branch
    Details- If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
  • 5. Add label Issue: Confirmed once verification is complete.
  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@engcom-Bravo engcom-Bravo added the Reported on 2.4.7 Indicates original Magento version for the Issue report. label Oct 7, 2024
@engcom-Bravo
Copy link
Contributor

Hi @wubinworks,

Thanks for your reporting and collaboration.

We have verified the issue in Latest 2.4-develop instance and seems to be an improvement to proceed further we are considering this as Feature Request.

Thanks.

@wubinworks
Copy link
Author

wubinworks commented Oct 8, 2024

@engcom-Bravo

I need to clarify, this is not a "Feature Request", it is a Bug, or say Fault.

At least for disable_auto_group_change attribute.
Please read the official document.

If enabled, you can override VAT ID Validation for individual customers by selecting the checkbox on the Customer Information page.

That's what the checkbox controls.
In no way should the customer be able to change this attribute by itself, even via WebAPI.
If the customer can change, it may result in incorrect tax payment.

PS: a similar issue, 2.4.6 -> 2.4.7, Magento fixed the ability to change created_at attribute.
See v2.4.7 CustomerRepository.php#Line218. You can compare with v2.4.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Ready for Grooming
Development

No branches or pull requests

2 participants