Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable product regular price shown including tax while configured to show prices without tax #38800

Open
1 of 5 tasks
oskar-olaussen opened this issue Jun 5, 2024 · 11 comments
Labels
Area: Tax Component: Ui Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: needs update Additional information is require, waiting for response Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: ready for dev Reported on 2.4.6-p2 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch

Comments

@oskar-olaussen
Copy link

Preconditions and environment

Magento version 2.4.6-p2

Tax class "Taxable Goods" set with some tax rate. I used 24%.

Tax settings:
tax/calculation/price_includes_tax set to 1 (Catalog prices: Including tax)
tax/display/type set to 1 (Display Product Prices In Catalog: Excluding tax)

Steps to reproduce

  1. Tax class "Taxable Goods" set to some configurable child.
  2. Set a special price for that configurable child.
  3. Reindex
  4. Navigate to the configurable product page and select the child product.

Expected result

The child's regular price is shown excluding tax.

Actual result

The child's regular price is shown including tax.

Here are the prices set in the admin:
Screenshot from 2024-06-05 15-36-54
Screenshot from 2024-06-05 15-36-39

Here is what is shown on the front end:
Screenshot from 2024-06-05 15-38-02

The regular price should be shown excluding the tax but is shown including the tax instead.

Additional information

One possible fix would be to get the value excluding tax here:
https://github.com/magento/magento2/blob/2.4-develop/app/code/Magento/ConfigurableProduct/Block/Product/View/Type/Configurable.php#L299

Release note

No response

Triage and priority

  • Severity: S0 - Affects critical data or functionality and leaves users without workaround.
  • Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
  • Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
  • Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
  • Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.
Copy link

m2-assistant bot commented Jun 5, 2024

Hi @oskar-olaussen. Thank you for your report.
To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:


Join Magento Community Engineering Slack and ask your questions in #github channel.
⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.
🕙 You can find the schedule on the Magento Community Calendar page.
📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

Copy link

m2-assistant bot commented Jun 5, 2024

Hi @engcom-Bravo. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
  • 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
  • 4. Verify that the issue is reproducible on 2.4-develop branch
    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
  • 5. Add label Issue: Confirmed once verification is complete.
  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@engcom-Bravo engcom-Bravo added the Reported on 2.4.6-p2 Indicates original Magento version for the Issue report. label Jun 5, 2024
Copy link

m2-assistant bot commented Jun 5, 2024

Hi @engcom-Dash. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

    1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
    1. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
    1. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
    1. Verify that the issue is reproducible on 2.4-develop branch
      Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
      - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
      - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

@engcom-Dash
Copy link
Contributor

@magento give me 2.4-develop instance

Copy link

Hi @engcom-Dash. Thank you for your request. I'm working on Magento instance for you.

Copy link

@engcom-Dash
Copy link
Contributor

Hi @oskar-olaussen

Thanks for reporting and collaboration.

Verified the issue on Magento 2.4 dev instance but the issue is not reproducable.

The child's regular price is shown excluding tax.

Tax class "Taxable Goods" set with some tax rate. I used 24%.

Tax settings:
tax/calculation/price_includes_tax set to 1 (Catalog prices: Including tax)
tax/display/type set to 1 (Display Product Prices In Catalog: Excluding tax)

Steps to reproduce
Tax class "Taxable Goods" set to some configurable child.
Set a special price for that configurable child.
Reindex
Navigate to the configurable product page and select the child product.

Please refer the attached screenshots. Let us know if we missed anything.

Screenshot 2024-06-11 at 3 42 12 PM Screenshot 2024-06-11 at 3 42 44 PM Screenshot 2024-06-11 at 4 12 21 PM Screenshot 2024-06-07 at 11 20 15 AM Screenshot 2024-06-07 at 11 20 17 AM Screenshot 2024-06-11 at 4 20 08 PM Screenshot 2024-06-11 at 4 12 21 PM

@engcom-Dash engcom-Dash added the Issue: needs update Additional information is require, waiting for response label Jun 11, 2024
@oskar-olaussen
Copy link
Author

Hello @engcom-Dash

Sorry if I'm misunderstanding something, but your screenshot seems to verify to issue? The price in admin is 1000 and the configuration is that the admin price includes the tax. The frontend show the regular price as 1000 but according to the configurations it should be shown excluding the tax.

@engcom-Dash
Copy link
Contributor

Hi @oskar-olaussen

Thanks for reporting and collaboration.

I verified the issue on Magento 2.4 dev instance but the issue is reproducible.

Hence, Confirming the issue.

The child's regular price is shown including tax.

Tax class "Taxable Goods" set with some tax rate.

Screenshot 2024-06-11 at 3 42 12 PM Screenshot 2024-06-11 at 3 42 44 PM

Tax settings:
tax/calculation/price_includes_tax set to 1 (Catalog prices: Including tax)
tax/display/type set to 1 (Display Product Prices In Catalog: Excluding tax)

Steps to reproduce:

  1. Tax class "Taxable Goods" set to some configurable child.
  2. Set a special price for that configurable child.
  3. Reindex
  4. Navigate to the configurable product page and select the child product.

Please take a look at the screenshots I've attached.

Screenshot 2024-06-11 at 4 12 21 PM Screenshot 2024-06-07 at 11 20 15 AM Screenshot 2024-06-07 at 11 20 17 AM Screenshot 2024-06-11 at 4 20 04 PM

@engcom-Dash engcom-Dash added Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Component: Ui Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Area: Tax labels Jun 13, 2024
@github-jira-sync-bot
Copy link

✅ Jira issue https://jira.corp.adobe.com/browse/AC-12131 is successfully created for this GitHub issue.

Copy link

m2-assistant bot commented Jun 13, 2024

✅ Confirmed by @engcom-Dash. Thank you for verifying the issue.
Issue Available: @engcom-Dash, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Tax Component: Ui Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: needs update Additional information is require, waiting for response Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: ready for dev Reported on 2.4.6-p2 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch
Projects
Status: Ready for Development
Development

No branches or pull requests

4 participants