Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mandatory fields in admin for Magento_Company do not match the fields on my account page #38360

Open
jeroenalewijns opened this issue Jan 18, 2024 · 9 comments
Labels
Adobe Commerce The issue related to the Adobe Commerce(EE) or B2B functionality Area: Account Component: User Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: ready for dev Reported on 2.4.6-p3 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch

Comments

@jeroenalewijns
Copy link

Preconditions (*)

  1. PHP8.2
  2. Maria DB 10.6
  3. Magento Commerce (cloud) 2.4.6-p3

Steps to reproduce (*)

  1. Login in the admin and create a company
  2. Create for the company in step 1 a customer user
  3. Login as company on frontend http://www.xxx.nl/customer/account/login/
  4. Change created user details by clicking on the edit button
  5. Now the job title and phone number are required

Expected result (*)

  1. I expect that the job title and phone number aren't required because these aren't required in the admin section. Now you have to add these to change the details of the customer user.

Actual result (*)

  1. The job title and phone number are required.

I think that in the file vendor/magento/module-company/view/frontend/templates/company/management/dialog/customer/add.phtml ln26 and ln60 the data-validate="{required:true}" must be removed.

Copy link

m2-assistant bot commented Jan 18, 2024

Hi @jeroenalewijns. Thank you for your report.
To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:


Join Magento Community Engineering Slack and ask your questions in #github channel.
⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.
🕙 You can find the schedule on the Magento Community Calendar page.
📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

Copy link

m2-assistant bot commented Jan 18, 2024

Hi @engcom-Dash. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

    1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
    1. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
    1. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
    1. Verify that the issue is reproducible on 2.4-develop branch
      Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
      - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
      - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

@andrewbess
Copy link

Hello @engcom-Dash
Looks like we need to move this issue to the another project B2B, because contributors will not have possibility to fix it.
Thank you in advance.

@andrewbess
Copy link

Hello @jeroenalewijns
Thank you for your collaboration

It is true, the admin fields and frontend fields have different requirements

@andrewbess andrewbess added Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reported on 2.4.6-p3 Indicates original Magento version for the Issue report. labels Jan 18, 2024
@github-jira-sync-bot
Copy link

Unfortunately, not enough information was provided to create a Jira ticket. Please make sure you added the following label(s): Reproduced on 2.4.x, ^Area:.*

Once all required labels are present, please add Issue: Confirmed label again.

@github-jira-sync-bot github-jira-sync-bot removed the Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed label Jan 18, 2024
@m2-community-project m2-community-project bot added Issue: ready for confirmation Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed and removed Issue: ready for confirmation labels Jan 18, 2024
@github-jira-sync-bot
Copy link

Unfortunately, not enough information was provided to create a Jira ticket. Please make sure you added the following label(s): Reproduced on 2.4.x, ^Area:.*

Once all required labels are present, please add Issue: Confirmed label again.

@github-jira-sync-bot github-jira-sync-bot removed the Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed label Jan 18, 2024
@engcom-Dash engcom-Dash added the Adobe Commerce The issue related to the Adobe Commerce(EE) or B2B functionality label Jan 18, 2024
@engcom-Dash
Copy link
Contributor

Hi @jeroenalewijns

Thanks for reporting and collaboration.

Verified the issue on magento commerce dev instance and the issue is reproducible.

The job title and phone number are required in the account page and are not mandatory fields in admin for Magento_Company.

Please refer the screenshots attached.

38360_Confirmed

@engcom-Dash engcom-Dash added Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Component: User Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Area: Account labels Jan 22, 2024
@github-jira-sync-bot
Copy link

✅ Jira issue https://jira.corp.adobe.com/browse/AC-10887 is successfully created for this GitHub issue.

Copy link

m2-assistant bot commented Jan 22, 2024

✅ Confirmed by @engcom-Dash. Thank you for verifying the issue.
Issue Available: @engcom-Dash, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@engcom-Dash engcom-Dash added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Jan 23, 2024
@engcom-Hotel engcom-Hotel moved this to Ready for Development in High Priority Backlog Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Adobe Commerce The issue related to the Adobe Commerce(EE) or B2B functionality Area: Account Component: User Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: ready for dev Reported on 2.4.6-p3 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch
Projects
Status: Ready for Development
Development

No branches or pull requests

4 participants