Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorder feature allows you to purchase product from different stores on the website #37372

Open
1 of 5 tasks
Kaitaka48 opened this issue Apr 14, 2023 · 19 comments · May be fixed by #37373
Open
1 of 5 tasks

Reorder feature allows you to purchase product from different stores on the website #37372

Kaitaka48 opened this issue Apr 14, 2023 · 19 comments · May be fixed by #37373
Assignees
Labels
Area: Order Component: order status Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: PR in progress Reported on 2.4.4-p2 Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch

Comments

@Kaitaka48
Copy link

Kaitaka48 commented Apr 14, 2023

Preconditions and environment

  • Magento version 2.4.4-p2
  • Multi Website - one store - one storeview(or multi storeview) 
  • Customers can login on all websites.
    Kindly refer the screenshots.

スクリーンショット 2023-04-18 16 40 29

Steps to reproduce

  1. Customer login to "WebsiteA"
  2. Order product A from "StoreA" (order ID: 12345)
  3. Customer login to "websiteB"
  4. Reorder product(order ID: 12345) on My Account page

Expected result

product A cannot be purchased at "WebsiteB"

Actual result

product A can be purchased at "WebsiteB"

Additional information

'Product A' can only be ordered on website A

Release note

No response

Triage and priority

  • Severity: S0 - Affects critical data or functionality and leaves users without workaround.
  • Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
  • Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
  • Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
  • Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.
@m2-assistant
Copy link

m2-assistant bot commented Apr 14, 2023

Hi @Kaitaka48. Thank you for your report.
To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:


Join Magento Community Engineering Slack and ask your questions in #github channel.
⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.
🕙 You can find the schedule on the Magento Community Calendar page.
📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

@m2-assistant
Copy link

m2-assistant bot commented Apr 14, 2023

Hi @engcom-Dash. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

    1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
    1. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
    1. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
    1. Verify that the issue is reproducible on 2.4-develop branch
      Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
      - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
      - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

@m2-assistant
Copy link

m2-assistant bot commented Apr 14, 2023

Hi @engcom-Bravo. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
  • 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
  • 4. Verify that the issue is reproducible on 2.4-develop branch
    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
  • 5. Add label Issue: Confirmed once verification is complete.
  • 6. Make sure that automatic system confirms that report has been added to the backlog.

Kaitaka48 pushed a commit to Kaitaka48/magento2.4-tk that referenced this issue Apr 14, 2023
@Kaitaka48 Kaitaka48 linked a pull request Apr 14, 2023 that will close this issue
5 tasks
@ihor-sviziev ihor-sviziev changed the title Reorder feature allows you to purchase prodcut from different stores on the website Reorder feature allows you to purchase product from different stores on the website Apr 14, 2023
@engcom-Bravo
Copy link
Contributor

@magento give me 2.4-develop instance

@magento-deployment-service
Copy link

Hi @engcom-Bravo. Thank you for your request. I'm working on Magento instance for you.

@magento-deployment-service
Copy link

@engcom-Bravo
Copy link
Contributor

engcom-Bravo commented Apr 14, 2023

Hi @Kaitaka48,

Thank you for reporting and collaboration.

Could please provide more information regarding

1.We have to create Single website - Multiple stores(or)Single store -Multiple storeviews.(or) Multi Website - Single store.

2.Customer Account sharing options - Global (or) Per Website.

3.We have to you disable/enable reorder option for particular store/storeview.

Please provide information it is helpful for us to reproduce the issue.

Thanks.

@engcom-Bravo engcom-Bravo added the Issue: needs update Additional information is require, waiting for response label Apr 14, 2023
@Kaitaka48
Copy link
Author

Kaitaka48 commented Apr 18, 2023

Hi @engcom-Bravo,

I have answered your questions

>1.We have to create Single website - Multiple stores(or)Single store -Multiple storeviews.(or) Multi Website - Single store.

Multiple Websites - Single Store.

>2.Customer Account sharing options - Global (or) Per Website.

Global

>3.We have to you disable/enable reorder option for particular store/storeview.

All store/store view reorder options are enabled

ーーーーーーーーーーーーーーーーーーーーーーーーーーーーーーーーー

There was a mistake in the steps to reproduce.Please check the correction.

I have already created a PR(#37373), please refer to it.

Thanks

@engcom-Bravo
Copy link
Contributor

@magento give me 2.4-develop instance

@magento-deployment-service
Copy link

Hi @engcom-Bravo. Thank you for your request. I'm working on Magento instance for you.

@magento-deployment-service
Copy link

@engcom-Bravo
Copy link
Contributor

Hi @Kaitaka48,

Thanks for your update.

We have followed below steps to reproduce.

Steps to reproduce

  • Customer login to "WebsiteA"
  • Order product A from "StoreA" (order ID: 12345)
  • Customer login to "websiteB"
  • Reorder product(order ID: 12345) on My Account page

Screenshot 2023-04-19 at 2 21 56 PM

We are able to reproduce the issue in Magento 2.4 develop instance but it is an expected behaviour of Magento.When we set
Customer Account sharing options to GLOBAL It will Shares customer account information with every website and store in the installation.

Kindly refer this document https://experienceleague.adobe.com/docs/commerce-admin/customers/customer-accounts/customer-account-scope.html?lang=en and please let us know if you are still facing any issue.

Thanks.

@Kaitaka48
Copy link
Author

@engcom-Bravo

The important aspects of this issue,"Products that are only tied to a particular website can be purchased on other websites."
Then correct reproduce procedure is:

Preconditions:
Assume 'Website A' already exists (default website)

  1. add a new 'Website B'
  2. add a root category (Category Name: B) and subcategory (Category Name: b) dedicated to 'Website B'
  3. add a store, store view to 'Website B', Tie root categories added in 2.
  4. Customer account sharing option is a global
  5. the reorder option for a specific store/store view is enabled
  6. create product B that is only tied to 'Website B'
    ・Enable Product: Yes
    ・Attribute Set: Default
    ・Product Name: sampleB
    ・Categories:b
    ・Product in Websites: 'Website B'
  7. Create customer account
  8. Purchase "Product B" from "Website B" with logged in status
  9. Log in to 'Website A'(default website)
  10. Access to order history
  11. Do reorder(8. Product B)

The expected execution result is "Reorder cannot be completed", because Product B is a product not tied to 'Website A'
However, Magento completes reorder without any errors.

The store ID of the order object held by "current_order" is the store ID associated with the website where the product was purchased.

$order = $this->_coreRegistry->registry('current_order');
$reorderOutput = $this->reorder->execute($order->getIncrementId(), $order->getStoreId());

Wouldn't it be more natural to use the store ID of the Website you are currently ordering from?

Thanks

@engcom-Bravo
Copy link
Contributor

@magento give me 2.4-develop instance

@magento-deployment-service
Copy link

Hi @engcom-Bravo. Thank you for your request. I'm working on Magento instance for you.

@magento-deployment-service
Copy link

@engcom-Bravo
Copy link
Contributor

Hi @Kaitaka48,

Thanks for your update.

Verified the issue on Magento 2.4-develop instance and the issue is reproducible.Kindly refer the screenshots.

Preconditions:
Assume 'Website A' already exists (default website)

Steps to reproduce :

  • add a new 'Website B'
  • add a root category (Category Name: B) and subcategory (Category Name: b) dedicated to 'Website B'
  • add a store, store view to 'Website B', Tie root categories added in 2.
  • Customer account sharing option is a global
  • the reorder option for a specific store/store view is enabled
  • create product B that is only tied to 'Website B'

・Enable Product: Yes
・Attribute Set: Default
・Product Name: sampleB
・Categories:b
・Product in Websites: 'Website B'

  • Create customer account
  • Purchase "Product B" from "Website B" with logged in status
  • Log in to 'Website A'(default website)
  • Access to order history
  • Do reorder(8. Product B)

Screenshot 2023-04-25 at 2 11 35 PM

Screenshot 2023-04-25 at 2 10 14 PM

Product is not assigned to default website still we are able to place the order.

Hence confirming the issue.

Thanks

@engcom-Bravo engcom-Bravo removed the Issue: needs update Additional information is require, waiting for response label Apr 25, 2023
@engcom-Bravo engcom-Bravo added Area: Order Component: order status Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Apr 25, 2023
@github-jira-sync-bot
Copy link

✅ Jira issue https://jira.corp.adobe.com/browse/AC-8598 is successfully created for this GitHub issue.

@m2-assistant
Copy link

m2-assistant bot commented Apr 25, 2023

✅ Confirmed by @engcom-Bravo. Thank you for verifying the issue.
Issue Available: @engcom-Bravo, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@engcom-Hotel engcom-Hotel added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Apr 26, 2023
@engcom-Hotel engcom-Hotel moved this to Pull Request In Progress in High Priority Backlog Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Order Component: order status Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: PR in progress Reported on 2.4.4-p2 Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch
Projects
Status: Pull Request In Progress
Development

Successfully merging a pull request may close this issue.

5 participants