Skip to content

[Issue] Remove laminas/laminas-dependency-plugin dependency #36515

Closed
@m2-assistant

Description

@m2-assistant

This issue is automatically created based on existing pull request: #36495: Remove laminas/laminas-dependency-plugin dependency


Description (*)

This PR removes the laminas/laminas-dependency-plugin composer plugin.
The plugin was introduced in #26436 and its purpose is described as follows on their homepage:

This Composer plugin, when enabled in a project, intercepts requests to install packages from the zendframework and zfcampus vendors, and will replace them with the equivalents from the Laminas Project.

Reason why I think we should get rid of this, is that I'm currently unable to use a modern version of composer to install dependencies on the 2.4-develop branch:

$ composer --version
Composer version 2.4.4 2022-10-27 14:39:29

$ composer install
Installing dependencies from lock file (including require-dev)
Verifying lock file contents can be installed on current platform.
In Laminas\DependencyPlugin\DependencyRewriterV2::onPrePoolCreate
Your lock file does not contain a compatible set of packages. Please run composer update.

  Problem 1
    - laminas/laminas-dependency-plugin is locked to version 2.5.0 and an update of this package was not requested.
    - laminas/laminas-dependency-plugin 2.5.0 requires composer-plugin-api >=1.1.0 <2.3.0 -> found composer-plugin-api[2.3.0] but it does not match the constraint.

Which was a restriction added to that plugin in laminas/laminas-dependency-plugin@54d508a

I believe that after 2 years since Magento switched from Zend to Laminas, that this plugin is not really necessary anymore, most people will have gotten used to the Laminas components by now and should install those instead of the old Zend ones.

// cc @ihor-sviziev

Related Pull Requests

Fixed Issues (if relevant)

None that I know of

Manual testing scenarios (*)

  1. Use composer 2.3.x or 2.4.x
  2. Try to run composer install without getting errors

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

Metadata

Metadata

Assignees

Labels

Area: FrameworkComponent: ComposerIssue: ConfirmedGate 3 Passed. Manual verification of the issue completed. Issue is confirmedPriority: P2A defect with this priority could have functionality issues which are not to expectations.Progress: doneReported on 2.4.xIndicates original Magento version for the Issue report.Reproduced on 2.4.xThe issue has been reproduced on latest 2.4-develop branch

Type

No type

Projects

Status

Done

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions