-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Return full credit card type in the CustomerPaymentTokens query. #32368
Comments
The issue was exported from the internal JIRA. The link to the original JIRA issue: https://jira.corp.magento.com/browse/MC-39592 |
Hi @github-jira-sync-bot. Thank you for your report.
Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:
For more details, please, review the Magento Contributor Assistant documentation. Please, add a comment to assign the issue:
🕙 You can find the schedule on the Magento Community Calendar page. 📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket. 🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel ✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel |
@magento I am working on this |
Hi @engcom-November. Thank you for working on this issue.
|
✅ Jira issue https://jira.corp.adobe.com/browse/AC-7400 is successfully created for this GitHub issue. |
✅ Confirmed by @engcom-November. Thank you for verifying the issue. |
@magento give me 2.4-develop instance |
Hi @engcom-Lima. Thank you for your request. I'm working on Magento instance for you. |
Hi @engcom-Lima, here is your Magento Instance: https://380676027ad2cbefd40605a509955d89.instances-prod.magento-community.engineering |
While working on PWA-636 we realized that the CustomerPaymentTokens query is not returning the whole credit card type. For instance it returns
VI
which equates toVISA
. Right now we are maintaining a mapper on the UI for codes and their respective full card types enumerated from https://github.com/magento/magento2/blob/2.4-develop/app/code/Magento/Payment/view/base/web/js/model/credit-card-validation/credit-card-number-validator/credit-card-type.js . It works but I am creating this feature request ticket to see if you guys can return the full type as well. If the UI is maintaining such a mapper, every-time a new type gets added or removed from the list, we need to publish a new change. It would be helpful if the GQL query returned that details.Steps to reproduce
1. Configure Payflow Pro payment method with vault enabled from Magento Admin - Stores - Configuration - Sales - Payments methods - Paypal payflow pro.
2. Front end - login as customer
3. Add product to cart and make payment using credit card with use Save card option
4. Generate graphql customer token using generateCustomerToken mutation
5. Run the customerPaymentTokens query
Expected behavior
UI and GraphQL behavior should be consistent.
Actual result
card type displayed in the graphql response is not understandable.
type: "card" is displayed in Graphql response. On UI - under Payment information: Credit Card and card type displayed as VISA
The text was updated successfully, but these errors were encountered: