Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return full credit card type in the CustomerPaymentTokens query. #32368

Open
github-jira-sync-bot opened this issue Mar 4, 2021 · 10 comments · May be fixed by #32744
Open

Return full credit card type in the CustomerPaymentTokens query. #32368

github-jira-sync-bot opened this issue Mar 4, 2021 · 10 comments · May be fixed by #32744
Assignees
Labels
Area: Payments Component: GraphQL GraphQL Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P3 May be fixed according to the position in the backlog. Progress: PR in progress Progress: ready for grooming Project: GraphQL Reported on 2.4.x Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.

Comments

@github-jira-sync-bot
Copy link

github-jira-sync-bot commented Mar 4, 2021

While working on PWA-636 we realized that the CustomerPaymentTokens query is not returning the whole credit card type. For instance it returns VI which equates to VISA. Right now we are maintaining a mapper on the UI for codes and their respective full card types enumerated from https://github.com/magento/magento2/blob/2.4-develop/app/code/Magento/Payment/view/base/web/js/model/credit-card-validation/credit-card-number-validator/credit-card-type.js . It works but I am creating this feature request ticket to see if you guys can return the full type as well. If the UI is maintaining such a mapper, every-time a new type gets added or removed from the list, we need to publish a new change. It would be helpful if the GQL query returned that details.

Steps to reproduce
 1. Configure Payflow Pro payment method with vault enabled from Magento Admin - Stores - Configuration - Sales - Payments methods - Paypal payflow pro.
 2. Front end - login as customer
 3. Add product to cart and make payment using credit card with use Save card option
 4. Generate graphql customer token using generateCustomerToken mutation
 5. Run the customerPaymentTokens query

Expected behavior
UI and GraphQL behavior should be consistent.

Actual result
card type displayed in the graphql response is not understandable.
type: "card" is displayed in Graphql response. On UI - under Payment information: Credit Card and card type displayed as VISA

@github-jira-sync-bot
Copy link
Author

The issue was exported from the internal JIRA. The link to the original JIRA issue: https://jira.corp.magento.com/browse/MC-39592

@m2-assistant
Copy link

m2-assistant bot commented Mar 4, 2021

Hi @github-jira-sync-bot. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this


⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@Usik2203
Copy link
Contributor

@magento I am working on this

@m2-community-project m2-community-project bot added Progress: PR in progress Priority: P3 May be fixed according to the position in the backlog. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. and removed Progress: dev in progress labels Apr 14, 2021
@engcom-November engcom-November self-assigned this Dec 8, 2022
@m2-assistant
Copy link

m2-assistant bot commented Dec 8, 2022

Hi @engcom-November. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.4-develop branch

    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Add label Issue: Confirmed once verification is complete.

  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@engcom-November
Copy link
Contributor

Verified the issue on Magento 2.4-develop branch and the issue is reproducible. GraphQL behavior and UI behavior are not the same.
For the vault payment made using VISA credit card from front end, type is displayed as "card" in GraphQl, whereas on UI - Card type displayed as VISA. Hence updating the description & confirming this issue.
image
image

@engcom-November engcom-November added Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Component: GraphQL GraphQL Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Reported on 2.4.x Indicates original Magento version for the Issue report. labels Dec 8, 2022
@github-jira-sync-bot
Copy link
Author

✅ Jira issue https://jira.corp.adobe.com/browse/AC-7400 is successfully created for this GitHub issue.

@m2-assistant
Copy link

m2-assistant bot commented Dec 8, 2022

✅ Confirmed by @engcom-November. Thank you for verifying the issue.
Issue Available: @engcom-November, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@github-jira-sync-bot github-jira-sync-bot added Priority: P2 A defect with this priority could have functionality issues which are not to expectations. and removed Priority: P3 May be fixed according to the position in the backlog. labels Jul 13, 2023
@m2-community-project m2-community-project bot added the Priority: P3 May be fixed according to the position in the backlog. label Jul 17, 2023
@engcom-Lima engcom-Lima removed the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Jul 17, 2023
@engcom-Lima
Copy link
Contributor

@magento give me 2.4-develop instance

@magento-deployment-service
Copy link

Hi @engcom-Lima. Thank you for your request. I'm working on Magento instance for you.

@magento-deployment-service
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Payments Component: GraphQL GraphQL Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P3 May be fixed according to the position in the backlog. Progress: PR in progress Progress: ready for grooming Project: GraphQL Reported on 2.4.x Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
Status: Pull Request In Progress
Development

Successfully merging a pull request may close this issue.

6 participants