Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Magento 2.4.1 translation issue on admin grids against different locales #31071

Open
mobeen-sarwar opened this issue Nov 26, 2020 · 19 comments
Open
Assignees
Labels
Area: Admin UI Component: Locale Component: Translation Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P3 May be fixed according to the position in the backlog. Progress: dev in progress Reported on 2.3.4-p2 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.

Comments

@mobeen-sarwar
Copy link

mobeen-sarwar commented Nov 26, 2020

Summary (*)

In the scenario of different locales, all admin grids are not translating to the relevant language package. Visit some admin grid like (Admin->sales->transactions) and then change the locale (admin -> Account Settings) to some other locale. Now previously visited admin grid should be translated according to the new locale, but this does not happen.

Preconditions (*)

1- Magento 2.4.1
2- Magento 2.3.4-p2
3- Magento 2.3.5-p2
4- Translations for at least two locales
5. Not reproducible on 2.4-develop

Assumptions(*)

1- We are assuming that we have three locales English, Japanese, and Korean, with translations.
locales
2- Make sure we have added translations for this path: Admin->Sales->Transactions

Steps to reproduce (*)

1- Login to Magento admin

2- Go to this path: Admin->Sales->Transactions and note down header translations. This step is a must. To test the translation changes for a grid you must visit it before changing your locale (step 3).

image

3- Now set the Interface Locale to Korean assuming the previous was English US (Go to admin -> Account Settings).

4- Must not flush the cache after changing the locale.

5- Repeat step 2.

Expected result (*)
1- Grid headers should be translated into Korean.

Actual result (*)
1- Grid headers are still in English.

transaction-jp

Further Details(*)

1- This translation is also on the below paths:
i) Admin->All Customers->Edit (open a customer details)->Reward Points->Reward Points History
ii) Admin->Sales->Orders->view(open an order details)->Transactions

2- Video recording of this issue

3- My previous ticket on this issue (magento 2.3.4)

@m2-assistant
Copy link

m2-assistant bot commented Nov 26, 2020

Hi @mobeen-sarwar. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this


⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@mobeen-sarwar
Copy link
Author

@magento give me 2.4-develop instance

@magento-deployment-service
Copy link

Hi @mobeen-sarwar. Thank you for your request. I'm working on Magento instance for you.

@mobeen-sarwar
Copy link
Author

Hi @engcom-Alfa

I need your support and help here.

Thank you!

@mobeen-sarwar
Copy link
Author

Hi @mobeen-sarwar, here is your Magento Instance: https://6a30a9a23463c2dae304b4c097ea9b27-2-4-develop.instances.magento-community.engineering
Admin access: https://6a30a9a23463c2dae304b4c097ea9b27-2-4-develop.instances.magento-community.engineering/admin_d17d
Login: 78b09f90
Password: a5457ca19a0f

@magento-deployment-service

This Magento Instance did not have a language pack against different Interface locales.

Thank you!

@engcom-Bravo engcom-Bravo self-assigned this Dec 1, 2020
@m2-assistant
Copy link

m2-assistant bot commented Dec 1, 2020

Hi @engcom-Bravo. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.4-develop branch

    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Add label Issue: Confirmed once verification is complete.

  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@engcom-Bravo engcom-Bravo added the Reported on 2.3.4-p2 Indicates original Magento version for the Issue report. label Dec 1, 2020
@engcom-Bravo
Copy link
Contributor

The issue is reproducible on 2.4.1 but not reproducible on the latest 2.4-develop.

@engcom-Bravo engcom-Bravo added Component: Translation Component: Locale Priority: P2 A defect with this priority could have functionality issues which are not to expectations. labels Dec 2, 2020
@engcom-Bravo engcom-Bravo removed the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Dec 2, 2020
@engcom-Bravo engcom-Bravo added Priority: P3 May be fixed according to the position in the backlog. Progress: dev in progress labels Dec 2, 2020
@engcom-Bravo engcom-Bravo added the Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. label Dec 2, 2020
@engcom-Bravo engcom-Bravo added Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Dec 2, 2020
@magento-engcom-team
Copy link
Contributor

✅ Confirmed by @engcom-Bravo
Thank you for verifying the issue. Based on the provided information internal tickets MC-39541 were created

Issue Available: @engcom-Bravo, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@stale
Copy link

stale bot commented Feb 16, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 14 days if no further activity occurs. Is this issue still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? Thank you for your contributions!

@stale stale bot added the stale issue label Feb 16, 2021
@mobeen-sarwar
Copy link
Author

@magento I am working on this

@m2-assistant
Copy link

m2-assistant bot commented Feb 19, 2021

Hi @mobeen-sarwar! 👋
Thank you for collaboration. Only members of Community Contributors Team are allowed to be assigned to the issue. Please use @magento add to contributors team command to join Contributors team.

@stale stale bot removed the stale issue label Feb 19, 2021
@mobeen-sarwar
Copy link
Author

@magento add to contributors team

@m2-assistant
Copy link

m2-assistant bot commented Feb 19, 2021

Hi @mobeen-sarwar! 👋
Thank you for joining. Please accept team invitation 👉 here 👈 and add your comment one more time.

@mobeen-sarwar
Copy link
Author

@magento add to contributors team

@mobeen-sarwar
Copy link
Author

@magento I am working on this

@engcom-Delta
Copy link
Contributor

Hi @mobeen-sarwar,

Thanks for your reporting and collaboration.
We have verified the issue in latest 2.4-develop instance and it is reproducible.
Hence, Confirming the issue.

Steps to reproduce:-

  1. Install Korean Language pack
  2. Create 2 store views
  3. Set locale as "Korean (south korea)"
  4. Create an admin user with Interface locale as "Korean (south korea)
  5. Login with respective admin user
  6. Observe admin menu items are displaying in korean.
  7. Navigate to Admin->Sales->Transactions or Customer > All Customers > Details
  8. Observe grid header is not fully translated, still some content is displaying in english.
    image
    image

Thanks.

@engcom-Delta engcom-Delta added Area: Admin UI Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed and removed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Aug 8, 2024
@github-jira-sync-bot
Copy link

✅ Jira issue https://jira.corp.adobe.com/browse/AC-12717 is successfully created for this GitHub issue.

Copy link

m2-assistant bot commented Aug 8, 2024

✅ Confirmed by @engcom-Delta. Thank you for verifying the issue.
Issue Available: @engcom-Delta, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Admin UI Component: Locale Component: Translation Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P3 May be fixed according to the position in the backlog. Progress: dev in progress Reported on 2.3.4-p2 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
Status: Dev In Progress
Development

No branches or pull requests

6 participants