Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation issue in admin grid on different locales #31050

Closed
mobeen-sarwar opened this issue Nov 25, 2020 · 5 comments
Closed

Translation issue in admin grid on different locales #31050

mobeen-sarwar opened this issue Nov 25, 2020 · 5 comments
Assignees
Labels
Issue: ready for confirmation not-confirmed Use for Issue that was closed during confirmation Reported on 2.3.4-p2 Indicates original Magento version for the Issue report.

Comments

@mobeen-sarwar
Copy link

Preconditions (*)

1- Magento 2.3.4-p2
2- Magento 2.3.5-p2
3- Translations for at least two locales

Assumptions(*)
1- We are assuming that we have three locales English, Japanese, and Korean, with translations.
image
2- Make sure we have added translations for this path Admin->Sales->Orders->view(open an order details)->Transactions

Steps to reproduce (*)

1- Login to Magento admin
2- Go to this path Admin->Sales->Orders->view(open an order details)->Transactions and note down header translations
image

3- Now set the Interface Locale to Korean assuming the previous was English US (Go to admin -> Account Settings).
4- Repeat step 2.

Expected result (*)
1- Grid headers should be translated into Korean.

Actual result (*)
1- Grid headers are still in English.
image

@m2-assistant
Copy link

m2-assistant bot commented Nov 25, 2020

Hi @mobeen-sarwar. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this


⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@mobeen-sarwar
Copy link
Author

@ajijshekh123

@engcom-Alfa engcom-Alfa self-assigned this Nov 25, 2020
@m2-assistant
Copy link

m2-assistant bot commented Nov 25, 2020

Hi @engcom-Alfa. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.4-develop branch

    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Add label Issue: Confirmed once verification is complete.

  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@engcom-Alfa engcom-Alfa added the Reported on 2.3.4-p2 Indicates original Magento version for the Issue report. label Nov 25, 2020
@engcom-Alfa
Copy link
Contributor

Hi @mobeen-sarwar .

Unfortunatelly, we are not able to reproduce this issue on fresh 2.4-develop.
Everything works as expected.

Actual Result:

✔️ Japanese Language

Screenshot from 2020-11-25 15-10-15

✔️ Korean Language

Screenshot from 2020-11-25 15-45-08

So, we have to close it.
Please feel free to comment, reopen or create new ticket according to the Issue reporting guidelines
if you are still facing this issue on the latest 2.4-develop branch. Thank you for collaboration.

@engcom-Alfa engcom-Alfa added the not-confirmed Use for Issue that was closed during confirmation label Nov 25, 2020
@mobeen-sarwar
Copy link
Author

Hi @engcom-Alfa

Thanks for your humble responce. I already checked it on Magento 2.4 and found no issue there. I'm facing this issue on Magento 2.3.4-p2 and Magento 2.3.5-p2. So I'm looking a fix for Magento 2.3.4-p2 version.

Many thanks for your instant response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue: ready for confirmation not-confirmed Use for Issue that was closed during confirmation Reported on 2.3.4-p2 Indicates original Magento version for the Issue report.
Projects
None yet
Development

No branches or pull requests

2 participants