Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error on checkout if customer selects billing address and image address attribute is present #30293

Open
magento-engcom-team opened this issue Oct 1, 2020 · 9 comments
Assignees
Labels
Area: Cart & Checkout Area: Payments CD Issue recommended for the contribution day Component: Other Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: dev in progress Reported on 2.3.5 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S2 Major restrictions or short-term circumventions are required until a fix is available.

Comments

@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Oct 1, 2020

Customer can not checkout if he selects billing address which differs from shipping one and custom customer address attribute of image type is present

Steps to Reproduce:

  1. Login as Admin
  2. Create new custom customer address attribute (Store -> Attributes -> Customer Address):
    #* Type = Image
  3. On Frontend create customer
  4. Add default address (for both shipping and billing) and upload some image to newly created attribute
  5. Add another address
  6. Start checkout process
  7. Select some address at shipping step
  8. Pass to payments step
  9. Untick checkbox 'My billing and shipping address are the same'
  10. Select some address from dropdown
  11. Click Update button

Actual Result:
(-) A piece of code is shown (see screenshot)
image

Expected Result:
(/) Values for all attributes are shown correctly
(/) Customer is able to finish checkout process successfully

@magento-engcom-team magento-engcom-team added Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: ready for dev Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. labels Oct 1, 2020
@magento-engcom-team
Copy link
Contributor Author

The issue was exported from the internal JIRA. The link to the original JIRA issue: https://jira.corp.magento.com/browse/MC-33704

@m2-assistant
Copy link

m2-assistant bot commented Oct 1, 2020

Hi @magento-engcom-team. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this


⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@magento-engcom-team magento-engcom-team added Component: Other Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch labels Oct 1, 2020
@magento-engcom-team
Copy link
Contributor Author

✅ Confirmed by @magento-engcom-team
Thank you for verifying the issue. Based on the provided information internal tickets MC-33704 were created

Issue Available: @magento-engcom-team, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@magento-engcom-team magento-engcom-team added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Oct 1, 2020
@sivaschenko sivaschenko added the CD Issue recommended for the contribution day label Oct 7, 2020
@ghost
Copy link

ghost commented Oct 10, 2020

@magento I am working on this

@m2-assistant m2-assistant bot assigned ghost Oct 10, 2020
@ghost ghost removed their assignment Nov 4, 2020
@sdzhepa sdzhepa added the Reported on 2.3.5 Indicates original Magento version for the Issue report. label Nov 11, 2020
@viniciusbordinhao-blueacorn
Copy link
Contributor

@magento I am working on it.

@viniciusbordinhao-blueacorn
Copy link
Contributor

@magento-engcom-team

This issue is not reproducible on Community Edition since the media_image type is banned from the frontend and backend as an attribute like you can see below:

https://github.com/magento/magento2/blob/2.4-develop/app/code/Magento/Customer/Model/Address/DataProvider.php#L216

I am not even able to create the attribute via admin panel like the steps to reproduce the issue suggested. It is not available for CE as well. I think the issue should be reported as an EE issue not like CE.

Please let me know if I have forgotten something regarding it.

@lagunacellar
Copy link

This may be EE specific. We are running Magento 2.4.1 on Cloud and encountering this issue repeatedly. See screenshots attached.

Checkout-1 shows the initial state at Review & Payments step, Place Order button is greyed out until customer confirms billing address.

Checkout-2 shows what happens after customer selects My billing and shipping addresses are the same.

checkout-1
checkout-2

@mehdichaouch
Copy link

mehdichaouch commented May 4, 2021

I got the same issue on a new Magento 2.4.2 EE !

Remove _.values
from _.values(currentBillingAddress().street).join(', ')
to get (currentBillingAddress().street).join(', ')
in vendor/magento/module-checkout/view/frontend/web/template/billing-address/details.html
in vendor/magento/module-checkout-address-search/view/frontend/web/template/billing-address/details.html

Change those file by overriding it in your theme
app/design/frontend/<theme_dir>/default/Magento_Checkout/web/template/billing-address/details.html.
app/design/frontend/<theme_dir>/default/Magento_CheckoutAddressSearch/web/template/billing-address/details.html.

This worked for me.

source

@Scarbous
Copy link
Contributor

Scarbous commented Jul 6, 2021

In Mageneto 2.4.2-p1
I fixed it this way:

require(['Magento_Checkout/js/model/quote'], function(q){
console.log(q.billingAddress().street.toArray().join(', '))
});

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Cart & Checkout Area: Payments CD Issue recommended for the contribution day Component: Other Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: dev in progress Reported on 2.3.5 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S2 Major restrictions or short-term circumventions are required until a fix is available.
Projects
Status: Dev In Progress
Development

No branches or pull requests

8 participants