Skip to content

[Issue] add subnet mask IP support for maintenance mode #29657

Closed
@m2-assistant

Description

@m2-assistant

This issue is automatically created based on existing pull request: #28934: add subnet mask IP support for maintenance mode


Description

Maintenance mode should accept IP ranges instead of separate IP's so that for instance you can add the whole range of your payment service provider or CDN etc...

Fixed Issues (if relevant)

  1. PR add subnet mask IP support for maintenance mode #10570

Manual testing scenarios

  1. run bin/magento maintenance:enable
  2. run bin/magento maintenance:allow-ips 192.168.33.0/16 (for instance)
  3. get access to the site

Mostly I am curious what you think about this kind of functionality and the use of darsyn/ip for this. I did take IPv6 into account.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

Metadata

Metadata

Labels

Component: AppComponent: ComposerComponent: HTTPComponent: SetupIssue: Format is not validGate 1 Failed. Automatic verification of issue format is failedPriority: P3May be fixed according to the position in the backlog.Progress: doneReported on 2.1.xIndicates original Magento version for the Issue report.Reproduced on 2.4.xThe issue has been reproduced on latest 2.4-develop branchSeverity: S3Affects non-critical data or functionality and does not force users to employ a workaround.Triage: Dev.ExperienceIssue related to Developer Experience and needs help with Triage to Confirm or Reject it

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions