Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue] Added getScopeCacheKey in order to define the right cache key based on store ID #28142

Open
4 tasks
ghost opened this issue May 7, 2020 · 0 comments · May be fixed by #27142
Open
4 tasks

[Issue] Added getScopeCacheKey in order to define the right cache key based on store ID #28142

ghost opened this issue May 7, 2020 · 0 comments · May be fixed by #27142
Assignees
Labels
Component: Catalog Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. Progress: PR in progress Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it
Milestone

Comments

@ghost
Copy link

ghost commented May 7, 2020

This issue is automatically created based on existing pull request: #27142: Added getScopeCacheKey in order to define the right cache key based on store ID


Description (*)

This PR adds an small improvement to the instance cache into the categories repository cause it allows to receive store id or store code for attributes data retrieval but at the same time this store id / code is used as cache key which make it a double unnecessary category load when you request the category by same given store, first providing the store id and then providing store code.

Manual testing scenarios (*)

  1. Into your own class load the category repository via di.
  2. Use the category repository to get a given category providing an specific store ID. Check the given category got stored into the cached instances array of the repository under the store ID.
  3. Use the category repository to get a given category (same category as previous point) providing a specific store Code (same store as previous point). Error should be thrown with this fix, otherwise it was loading again the category filtering by store code which is incorrect based on PHP Docs into the interface.

Questions or comments

Have in mind this issue is not reproducible from REST API given it enforces to use the store ID based on the PHP Docs from the interface.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)
@ghost ghost added Component: Catalog Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels May 7, 2020
@ghost ghost assigned matiashidalgo May 7, 2020
@magento-engcom-team magento-engcom-team added the Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed label May 7, 2020
@ghost ghost added the Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. label May 27, 2020
@m2-community-project m2-community-project bot added Progress: PR Created Indicates that Pull Request has been created to fix issue and removed Progress: PR Created Indicates that Pull Request has been created to fix issue labels Sep 24, 2020
@m2-community-project m2-community-project bot added Progress: PR in progress and removed Progress: PR Created Indicates that Pull Request has been created to fix issue labels Jan 7, 2021
@gabrieldagama gabrieldagama added this to the 2.5 milestone Jan 25, 2021
@engcom-Dash engcom-Dash added the Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it label Mar 7, 2024
@engcom-Hotel engcom-Hotel moved this to Pull Request In Progress in Low Priority Backlog Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Catalog Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. Progress: PR in progress Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it
Projects
Status: Pull Request In Progress
4 participants