Store View Switching

[moe-kayali]

Hello,

Looks like there is an issue with store views switching on Magento 2 on the frontend, when "Add Store Code to Urls" option is enabled.
When the option is enabled, store views switcher will get stuck and I won't be able to switch to another store view.

I attached a gif image to show you how to reproduce it. Thanks.
(In the gif, cache is disabled on the website. I also tested with cache enabled)

Hi,

just took a quick look and need some rechecks but from what I saw:

I think that Magento\Store\Controller\Store\SwitchAction does not consider this option, or I am not able to see this.
A possible solution could be, to add a check into the Controllers execute method.
Example solution SwitchAction->execute()

        $redirectUrl = $this->_redirect->getRedirectUrl();
        if($store->isUseStoreInUrl())
        {
            $redirectUrl = $store->getBaseUrl();
        }
        $this->getResponse()->setRedirect($redirectUrl);

This would allow to redirect to the correct url.

As I just said, just did some quick tests and it works but I think I should make further checks to be 100% sure.
If you like I can pass a PR for this.

Best

[coolshot]

Hello, i tested this fix and apparently it works
But, when you switch from any page but the home page, it brings you to the home page and not to the store view of the item you were on.
Ex. mystore.test/it/prodotto.htm does not go to mystore.test/en/product.htm but to mystore.test/en/

S

[coolshot]

An addition to the above comment:
The behaviour (reset to base url when switching language) happens from any item, be it csm page, product or category when Store Code Urls is active.

If I get the chance I will take a deeper look. This last one was just a quick shot, which was not tested thoroughly. I think I'll go ahead and make a full PR next week.

[cescopag]

Same problem here with Magento 2.0.1 EE

[olllip]

Same problem here with Magento 2.0.2
Any chance to fix it?

[philipvandebriel]

For me also same problem with Magento 2.0.2

[mazhalai]

Thank you all, we have created MAGETWO-51294 to investigate and fix.

[gplanchat]

Same issue on EE

[hshar7]

@coolshot Could you please explain your observations a little further? The way were thinking about fixing this is very close to what @xhallix said. I am able to switch between store views without any problem after the fix. No redirection to default store view when switching from one to anther.

Take a look at patch: http://pastebin.com/s9anwxhv

[coolshot]

@hshar7 gonna test it over the weekend and post feedback, thank you