Check Data should validate gallery information

[barbazul]

Current implementation ignores media gallery information during data check and then, if data is invalid (i.e. a row is missing the _media_attribute value) errors might occur.

I confirmed this bug in 1.7.0.2 and could not test in magento2 due to not having a PHP < 5.4 available at the moment. I did, however check magento2 code and it looks as if it is still there since there is no validation of media gallery data furing the first step and in app/code/core/Mage/ImportExport/Model/Import/Entity/Product.php line 1275 it blindly assigns $insertValue['attribute_id'] to $valueArr['attribute_id'] which gets passed to the database "as is" in line 1281 and raises an SQL exception if its null

[piotrekkaminski]

Hello. Would you be able to contribute a pull request with a fix?

[barbazul]

I could code a fix for 1.7.0.2 (I already have) then port it to magento2
and hope for the best. I wouldn't be able to test it because of the pending
issue with the admin panel in 5.4
El abr 2, 2013 7:14 AM, "piotrekkaminski" notifications@github.com
escribió:

Hello. Would you be able to contribute a pull request with a fix?

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/271#issuecomment-15767073
.

[piotrekkaminski]

Thanks. That would help as well.

[barbazul]

Ok, I have a fix for the specific _media_attribute_id error. At this point I am wondering:

1. Should the file be validated? Right now if file is missing its ignored during the import step (can't tell you how many headaches this has brought me) but I worry that checking it with file_exists would make the validation process too slow.
2. Should the _media_attribute be validated as being the actual media_gallery attribute? Right now, if you provide a wrong attribute_id, it is saved into catalog_product_entity_media_gallery as it is provided, which creates rows that will never be accessed.
3. Why is there even such a column? Looking at Mage_Catalog_Model_Product::addImageToMediaGallery, it specifically looks for the media_gallery attribute code (which obviously maps to an attribute_id later on). Why is there the need to specify the _media_attribute_id column? why not load the attribute, look for its id and use that? I am guessing the intention at some point was to have multiple media galleries for one product but, since the attribute code is hardwired into the models involved I guess that idea was abandoned

[piotrekkaminski]

Thank you. We will review this thread and try to answer the questions.

[barbazul]

@piotrekkaminski Did you get a chance to look into this?

[verklov]

Hello barbazul,
We have processed your pull request. The code is released in version dev54.