Skip to content

Validate html error when enable critical css #26760

Closed
@minhluan259

Description

@minhluan259

Preconditions (*)

  1. Magento 2.3.4

Steps to reproduce (*)

  1. Enable Critial CSS
  2. Validate html https://validator.w3.org/

Expected result (*)

  1. Validate html without error

Actual result (*)

  1. Validate html error
    https://prnt.sc/qz5dz9

$loadCssAsync = sprintf(
'<link rel="preload" as="style" media="%s" .
onload="this.onload=null;this.rel=\'stylesheet\'"' .
'href="%s">',
$media,
$href
);

need change to

                    $loadCssAsync = sprintf(
                        '<link rel="preload" as="style" media="%s" 
                         onload="this.onload=null;this.rel=\'stylesheet\'"' .
                        ' href="%s">',
                        $media,
                        $href
                    );

Metadata

Metadata

Assignees

No one assigned

    Labels

    Component: ThemeFixed in 2.4.xThe issue has been fixed in 2.4-develop branchIssue: Clear DescriptionGate 2 Passed. Manual verification of the issue description passedIssue: ConfirmedGate 3 Passed. Manual verification of the issue completed. Issue is confirmedIssue: Format is validGate 1 Passed. Automatic verification of issue format passedIssue: Ready for WorkGate 4. Acknowledged. Issue is added to backlog and ready for developmentProgress: PR CreatedIndicates that Pull Request has been created to fix issueReported on 2.3.4Indicates original Magento version for the Issue report.Reproduced on 2.4.xThe issue has been reproduced on latest 2.4-develop branch

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions