setHasOptions when save product

[bernd-reindl]

Preconditions (*)

Magento 2.3.3 & 2.3-develop

Steps to reproduce (*)

Check values in the catalog_product_entity table before

1. Load a product (type_id 'bundle') in a custom module ($model->load($entityId);)
2. change any value ($model->setAnyValue('test');)
3. save the product (model->save();)

You can use this code:

$objectManager = \Magento\Framework\App\ObjectManager::getInstance();
$productFactory = $objectManager->create('\Magento\Catalog\Model\ProductFactory');
$product = $productFactory->create();
$sku = 'testbundle';
$product->load($product->getIdBySku($sku));
$product->setSku('Test1234');
$product->save();

Expected result (*)

1. the fields 'has_options' and 'required_options' should not changed because there are no modifications in custom options or bundle options.

Actual result (*)

1. the fields 'has_options' and 'required_options' has changed to 0 (before save it was 1) because in module-catalog/Model/Product.php in function 'beforeSave' the values for 'has_options' and 'required_options' was set to false. But i think this values should only changed if 'canAffectOptions()' returns true. Else 'canAffectOptions()' would not make any sense. See comment (Set false, ONLY if options have been affected by Options tab and Type instance tab)

My solution is to comment out '$this->setHasOptions(false);' ans '$this->setRequiredOptions(false);' at the beginning of beforeSave because this values will be set to false later by condition '} elseif ($this->canAffectOptions()) {'.

[m2-assistant]

Hi @bernd-reindl. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

• Summary of the issue
• Information on your environment
• Steps to reproduce
• Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.3-develop instance - upcoming 2.3.x release

For more details, please, review the Magento Contributor Assistant documentation.

@bernd-reindl do you confirm that you were able to reproduce the issue on vanilla Magento instance following steps to reproduce?

• yes
• no

---

• Join Magento Community Engineering Slack and ask your questions in #github channel.

[m2-assistant]

Hi @engcom-Charlie. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

  Details

  If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

• 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• 4. Verify that the issue is reproducible on 2.3-develop branch

  Details

  - Add the comment @magento give me 2.3-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

• 5. Add label Issue: Confirmed once verification is complete.

• 6. Make sure that automatic system confirms that report has been added to the backlog.

[bernd-reindl]

How can i add Issue: Clear Description?

Its not possible to test this on a develop instance, because i have to add a module to save the product (bundle) programmatically.

[engcom-Charlie]

Hello @bernd-reindl
I have to add all labels to the issue. That is not your problems : )

[magento-engcom-team]

✅ Confirmed by @engcom-Charlie
Thank you for verifying the issue. Based on the provided information internal tickets MC-29253 were created

Issue Available: @engcom-Charlie, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.