Filtering a collection on a custom attribute and a custom store_id generate wrong sql request

[alexmtch]

Preconditions (*)

1. Magento CE 2.3.2
2. Php 7.1
3. developer (or production ?) mode

Steps to reproduce (*)

1. Create a custom attribute with a store_id scope
2. Create a product, attach it to a new store view (not the website or the store group) and set a value for the specific store to the custom attribute
3. Create a product collection on a custom attribute following this code :

$products = $this->productFactory->create()
                ->getCollection()
                ->addStoreFilter(2)
                ->addAttributeToFilter('custom_attribute', '123');

Expected result (*)

1. In my case i expected a result of a collection which contains 1 item

Actual result (*)

1. I got an empty collection

After a workaround i retrieve the sql request

SELECT `e`.*, IF(at_custom_attribute.value_id > 0, at_custom_attribute.value, at_custom_attribute_default.value) AS `custom_attribute` 
FROM `catalog_product_entity` AS `e`
INNER JOIN `catalog_product_website` AS `product_website` ON product_website.product_id = e.entity_id AND product_website.website_id = 2
INNER JOIN `catalog_product_entity_varchar` AS `at_custom_attribute_default` ON (`at_custom_attribute_default`.`entity_id` = `e`.`entity_id`) AND (`at_custom_attribute_default`.`attribute_id` = '163') AND `at_custom_attribute_default`.`store_id` = 0
LEFT JOIN `catalog_product_entity_varchar` AS `at_custom_attribute` ON (`at_custom_attribute`.`entity_id` = `e`.`entity_id`) AND (`at_custom_attribute`.`attribute_id` = '163') AND (`at_custom_attribute`.`store_id` = 2) WHERE (IF(at_custom_attribute.value_id > 0, at_custom_attribute.value, at_custom_attribute_default.value) = '123')

You see on the line 4 a join condition on the store id where the value is 0 while it should be 2. I fixed the sql request and run into mysql and i got the correct sql result.

After a workaround this is generated by the method _joinAttributeToSelect of this file vendor/magento/module-catalog/Model/ResourceModel/Collection/AbstractCollection.php

Update

I see in this method this comment

/**

• Add joining default value for not default store
• if value for store is null - we use default value
  */

I suppose by this comment that this declaration

$defCondition .= $connection->quoteInto(
                " AND " . $connection->quoteColumnAs("{$defAlias}.store_id", null) . " = ?",
                $this->getDefaultStoreId()
            );

should be

$defCondition .= $connection->quoteInto(
                " AND " . $connection->quoteColumnAs("{$defAlias}.store_id", null) . " = ?",
                $storeId ? $storeId : $this->getDefaultStoreId()
            );

What do you think about this ?

[m2-assistant]

Hi @alexmtch. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

• Summary of the issue
• Information on your environment
• Steps to reproduce
• Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.3-develop instance - upcoming 2.3.x release

For more details, please, review the Magento Contributor Assistant documentation.

@alexmtch do you confirm that you were able to reproduce the issue on vanilla Magento instance following steps to reproduce?

• yes
• no

---

• Join Magento Community Engineering Slack and ask your questions in #github channel.

[m2-assistant]

Hi @engcom-Bravo. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

  Details

  If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

• 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• 4. Verify that the issue is reproducible on 2.3-develop branch

  Details

  - Add the comment @magento give me 2.3-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

• 5. Verify that the issue is reproducible on 2.2-develop branch.

  Details

  - Add the comment @magento give me 2.2-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

• 6. Add label Issue: Confirmed once verification is complete.

• 7. Make sure that automatic system confirms that report has been added to the backlog.

[magento-engcom-team]

@engcom-Bravo Thank you for verifying the issue.

Unfortunately, not enough information was provided to acknowledge ticket. Please consider adding the following:

• Add "Component: " label(s) to this ticket based on verification result. If uncertain, you may follow the best guess

Once all required information is added, please add label "Issue: Confirmed" again.
Thanks!